Darwin: Add MTRCommissioningParameters.readEndpointInformation #37118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #37118: Size comparison from 593861d to a2e0df1 Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
ksperling-apple
force-pushed
the
read-device-types-darwin
branch
from
a2e0df1 to
b7dba6c
Compare
|
PR #37118: Size comparison from 593861d to b7dba6c Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Move MTRDeviceTypeRevision out of ServerEndpoint directory - Move MTRProductIdentity into its own file - Implement NSCopying and equality on MTRDeviceType and MTRProductIdentity - Implement description on all 3 types - Add tests
Endpoint information is made availalable to the delegate via an MTRCommissioneeInfo object containing MTREndpointInfo objects.
Co-authored-by: Boris Zbarsky <[email protected]>
…DeviceTypeList Also add some additional comments to parsing logic and a couple more tests.
ksperling-apple
force-pushed
the
read-device-types-darwin
branch
from
b7dba6c to
b2ff181
Compare
|
PR #37118: Size comparison from 46a1a38 to b2ff181 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Also conform to NSCopying, mark as sendable, and implement isEqual/hash.
ksperling-apple
force-pushed
the
read-device-types-darwin
branch
from
3cff2a3 to
e9af61f
Compare
|
PR #37118: Size comparison from 36f81cd to e9af61f Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jan 24, 2025
|
Fast-tracking platform-specific fix with platform owner review. |
|
PR #37118: Size comparison from 36f81cd to acee013 Increases above 0.2%:
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MTRCommissioningParameters.readEndpointInformation and make endpoint information available to the delegate via an MTRCommissioneeInfo object containing MTREndpointInfo objects.
This sits on top of the C++ SDK changes in #36867.
Also:
Testing