Skip to content

OpenThread: Guard ClearAllSrpHostAndServices with CHIP_DEVICE_CONFIG_ENABLE_THREAD_SRP_CLIENT. #38241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Apr 3, 2025
Merged

OpenThread: Guard ClearAllSrpHostAndServices with CHIP_DEVICE_CONFIG_ENABLE_THREAD_SRP_CLIENT. #38241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4412d5d
OpenThread: Guard ClearAllSrpHostAndServices with CHIP_DEVICE_CONFIG_…
shripad621git Apr 3, 2025
a74f777
.github/workflows: Added the thread-br-app in the CI tests for esp32s…
shripad621git Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/examples-esp32.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,3 +179,6 @@ jobs:

- name: Build example Lock App (Target:ESP32C6)
run: scripts/examples/esp_example.sh lock-app sdkconfig.defaults esp32c6

- name: Build example thread-br-app (Target:ESP32S3)
run: scripts/examples/esp_example.sh thread-br-app sdkconfig.defaults esp32s3
2 changes: 2 additions & 0 deletions src/platform/OpenThread/GenericNetworkCommissioningThreadDriver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,9 @@ CHIP_ERROR GenericThreadDriver::RevertConfiguration()
// since the fail-safe was armed, so return with no error.
VerifyOrReturnError(error != CHIP_ERROR_PERSISTED_STORAGE_VALUE_NOT_FOUND, CHIP_NO_ERROR);

#if CHIP_DEVICE_CONFIG_ENABLE_THREAD_SRP_CLIENT
ThreadStackMgrImpl().ClearAllSrpHostAndServices();
#endif

if (!GetEnabled())
{
Expand Down
Loading