Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PodLog function to retrieve Pod log using function #83

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Dec 3, 2024

Issue link

What changes have been made

Added PodLog function to be able to retrieve Pod log for gomega Eventually assertions.
Renamed GetPodLogs to GetPodLog to keep consistency, the previous function is not used anywhere.

Verification steps

N/A

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link

openshift-ci bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [astefanutti,sutaakar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit af25680 into project-codeflare:main Dec 3, 2024
3 checks passed
@sutaakar sutaakar deleted the misc branch December 3, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants