feat: Enrich peek_bundle + lock to expose bundle mcp inputs and secrets#2122
Conversation
|
Warning Review limit reached
Next review available in: 31 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
QA panel review — PASS
code-review-structural · head ad5db4b40db0 · formal
[review-synthesizer completed: workflow code-review-structural:report]
Prose Brief
Overall risk: Very low. The PR is 100% additive — every hunk is a + line, no existing behavior is altered, and the list(bundle.get("X") or []) guard pattern is identical to the one already proven in the "mcp" handling within installer.py. Both the bundle and single-plugin peek paths and the install lock path are covered by new tests.
Fix-first item: Nothing to fix. All four LLM finders converged on clean, and the verifier confirmed every claim against the diff and default-branch code.
Panel disagreement: None — unanimous clean verdict.
What verification changed: No findings were refuted or flagged uncertain. Every claim was SUPPORTED. Verification did surface one factual correction: the synthesis brief stated "mcp" was "plumbed" into the install lock path, but "mcp" already existed there in the default branch — only "secrets" is new to the lock; "mcp" is new only to the peek path. This doesn't affect any finding.
Gaps: The structural lane (protoPatch) errored with a rate-limit and produced no findings — a tooling gap, not a code defect. Both modified production files (ops/plugins.py, plugins/installer.py) were covered by the LLM panel, so coverage is adequate despite the structural miss.
[]…rtifacts, fleet inputs/secrets (#2130) Bump 0.106.0 → 0.107.0 and roll the changelog for the release. Highlights: - Versioned file artifacts + save_file_artifact (ADR 0092 D2, #2126) - Document-generation stack baked into the desktop bundle (ADR 0092 D1, #2123) - Fleet agents accept operator inputs + secrets at create time (#2121/#2122/#2125/#2127) - Deterministic persona-drift detection (#2116) - Chat tab context menu Close Others/Left/Right (#2112) - Fixes: archetype-catalog bundling (#2115), PyPI publishes on tag push (#2113) Backfilled [Unreleased] entries for the feature PRs that lacked them, rolled to [0.107.0], scaffolded + polished the marketing changelog. uv.lock: project version line only (surgical — avoids uv 0.11.13-vs-pinned-0.11.29 marker drift). Claude-Session: https://claude.ai/code/session_01EVmWoy2TdXdMshNn5WBR2Z Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Summary
Enriches the archetype-preview (
peek_bundle) response and the bundle lock to expose the inputs an archetype will ask the operator for — pure data enrichment, no behavior change.ops/plugins.py—_peek_bundle_syncnow surfaces the bundle manifest'smcp(catalog-shaped{template, inputs: [{key, label, …}]}items) andsecrets({key, label, placeholder, secret, required}items) in the peek result, soArchetypePreviewDialogcan show what the archetype will collect without installing. The single-plugin (non-bundle) peek branch carries both keys as[], so consumers readmcp/secretsuniformly across bundle and plugin previews.graph/plugins/installer.py—_install_bundlecachessecretsin theplugins.lockbundle entry, mirroring the existingmcpcache, so the lock-only workspace-create path can seed/prompt for these inputs without re-parsing the bundle.test_ops_plugins.pygains coverage that a bundle peek surfacesmcp/secretsand that a single-plugin peek returns both empty;test_plugin_installer.pyasserts the lock now cachesmcpandsecretsalongside the existing provenance fields (shared fixtures updated to declare both fields).Refs #2041 (slice 1 of 3)