Add PeerDAS custody columns metric #14815
Open
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KatyaRyazantseva
requested review from
potuz,
rkapka and
nisdas
and removed request for
a team
nalepae
reviewed
Jan 21, 2025
| @@ -33,4 +33,8 @@ var ( | |||
| Name: "blob_disk_bytes", | |||
| Help: "Approximate number of bytes occupied by blobs in storage", | |||
| }) | |||
| custodyColumnWrittenCounter = promauto.NewGauge(prometheus.GaugeOpts{ | |||
There was a problem hiding this comment.
Why using a gauge for a counter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This PR adds gossip verification metrics align with the PeerDAS metrics specs:
beacon_custody_columns_count_totalWhich issues(s) does this PR fix?
Fixes (partially) #14129
Other notes for review
Acknowledgements