Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PeerDAS custody columns metric #14815

Open
wants to merge 4 commits into
base: peerDAS
Choose a base branch
from
Open

Add PeerDAS custody columns metric #14815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45aba25
Add PeerDAS custody columns metric
KatyaRyazantseva Jan 20, 2025
dce83c0
Fix counter
KatyaRyazantseva Jan 21, 2025
55c5e50
Merge branch 'peerDAS' into peerdas-metrics-custody
KatyaRyazantseva Jan 21, 2025
7dcb7c3
Fix format
KatyaRyazantseva Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion beacon-chain/db/filesystem/blob.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ func (bs *BlobStorage) SaveDataColumn(column blocks.VerifiedRODataColumn) error
})
}

// TODO: Use new metrics for data columns
custodyColumnWrittenCounter.Inc()
blobsWrittenCounter.Inc()
blobSaveLatency.Observe(float64(time.Since(startTime).Milliseconds()))
return nil
Expand Down
4 changes: 4 additions & 0 deletions beacon-chain/db/filesystem/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,8 @@ var (
Name: "blob_disk_bytes",
Help: "Approximate number of bytes occupied by blobs in storage",
})
custodyColumnWrittenCounter = promauto.NewCounter(prometheus.CounterOpts{
Name: "beacon_custody_columns_count_total",
Help: "Total count of columns in custody within the data availability boundary",
})
)
2 changes: 1 addition & 1 deletion beacon-chain/sync/validate_data_column.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (

// https://github.com/ethereum/consensus-specs/blob/dev/specs/fulu/p2p-interface.md#the-gossip-domain-gossipsub
func (s *Service) validateDataColumn(ctx context.Context, pid peer.ID, msg *pubsub.Message) (pubsub.ValidationResult, error) {
dataColumnSidecarVerificationRequestsCounter.Inc();
dataColumnSidecarVerificationRequestsCounter.Inc()
receivedTime := prysmTime.Now()

// Always accept messages our own messages.
Expand Down
Loading