Implement api.json generation in pulp-docs #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-psb
force-pushed
the
gen-and-store-api-json-in-pulp-docs
branch
11 times, most recently
from
e46a59e to
0f32b6d
Compare
* Add openapi generation module + tests * Add pytest suite to CI. Only build sanity test was being run.
pedro-psb
force-pushed
the
gen-and-store-api-json-in-pulp-docs
branch
from
0f32b6d to
2be5c96
Compare
dkliban
approved these changes
Jun 28, 2024
mdellweg
reviewed
Jun 29, 2024
| install_cmd = ["pip", "install", "pulpcore"] | ||
| else: | ||
| url = f"git+{plugin.get_remote_url()}" | ||
| install_cmd = ["pip", "install", "pulpcore", url] |
There was a problem hiding this comment.
Each plugin depends on pulpcore. Why adding that here?
There was a problem hiding this comment.
Somehow I've ignored that.
mdellweg
reviewed
Jun 29, 2024
| if plugin.is_subpackage or plugin.name == "pulpcore": | ||
| if Path(self.venv_path).exists(): | ||
| return | ||
| install_cmd = ["pip", "install", "pulpcore"] |
There was a problem hiding this comment.
We install the others from git why is it different for pulpcore?
|
I'll send another PR with those fixes |
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR:
{plugin}-api.jsonusingpulpcore-manager openapicommand.