repo commands are signed by user's testbed cert #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies the trust schema to change how repository commands are authenticated. Instead of using workspace user certificates, repo commands are now signed by testbed certificates directly.
Key Changes:
- Introduces a new
#user_testbed_certpattern that validates user certificates signed directly by testbed authorities - Updates
#repo_cmdto require#user_testbed_certinstead of#user_certfor authorization
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ndn/app/schema.trust | Added #user_testbed_cert definition and updated #repo_cmd to use testbed certificates for authentication instead of workspace user certificates |
| ndn/app/schema.tlv | Compiled/binary representation of the trust schema, regenerated to reflect the changes in schema.trust |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.