-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing AWS and DigitalOcean tests #1497
Conversation
🍹 The Update for moolumi/k8s-ci-cluster/4b5971a00e4c2ae809eb170b787921e2499195e8-1518 was successful. Resource Changes Name Type Operation
+ gke pulumi:providers:kubernetes create
+ k8s-ci-cluster-4b5971a00e4c2ae809eb170b787921e2499195e8-1518 pulumi:pulumi:Stack create
+ multicloud pulumi-kubernetes:ci:GkeCluster create
+ password random:index/randomPassword:RandomPassword create
+ ephemeral-ci-cluster gcp:container/cluster:Cluster create
+ primary-node-pool gcp:container/nodePool:NodePool create
|
🍹 The Destroy for moolumi/k8s-ci-cluster/4b5971a00e4c2ae809eb170b787921e2499195e8-1518 was successful. Resource Changes Name Type Operation
- gke pulumi:providers:kubernetes delete
- primary-node-pool gcp:container/nodePool:NodePool delete
- ephemeral-ci-cluster gcp:container/cluster:Cluster delete
- password random:index/randomPassword:RandomPassword delete
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but how does this relate to #1492 and other associated issues?
Also appears to be related to #1491 |
Thanks for the review @scottslowe!
|
This PR fixes a few failing tests:
For
aws-py-ec2-provisioners
, tweaks the test assertion slightly to account for a change in the behavior of Pulumi Command. Until recently, the provider'sstdout
property was an output of string, but it's now marked as a secret (see pulumi/command#256), and I wasn't able to get the test framework to unwrap the secret. (Anton's comment on the linked issue seems to suggest that may not even possible.) So I've adjusted the test to check for a non-empty value instead, which to me seems fine for now. (The program itself is unaffected.) I also went ahead and updated the program to use the latest version of Pulumi Command as well.For
digitalocean-{py,cs}-loadbalanced-droplets
, updates the image ID used to provision DigitalOcean droplets. Apparently Ubuntu 18 is no longer valid.Fixes #1494.
Fixes #1484.
Fixes #1491.