Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure in CI: OSI website returns 403 (not a review) #133

Closed
isabelizimm opened this issue Sep 7, 2023 · 2 comments · Fixed by #139
Closed

Failure in CI: OSI website returns 403 (not a review) #133

isabelizimm opened this issue Sep 7, 2023 · 2 comments · Fixed by #139

Comments

@isabelizimm
Copy link
Contributor

In #130 and other PRs, the link checker is failing with

ERROR: 1 dead links found!
[✖] https://opensource.org/licenses → Status: 403

but if you go to the https://opensource.org/licenses, the website is up and running. I'm not quite sure why it is returning an error, but it is worth looking into!

@lwasser
Copy link
Member

lwasser commented Sep 7, 2023

Thank you @isabelizimm !! What we can do is have htmlproofer ignore 403 error codes. Sometimes websites are sensitive to being accessed by ci for whatever reason.

If you go to our package guide build you can see how to do it with html proofer. https://github.com/pyOpenSci/python-package-guide/blob/main/.github/workflows/build-book.yml I'm not at my computer now but hope there is a way to implement the same w the link checker we have here for markdown?

@lwasser
Copy link
Member

lwasser commented Sep 11, 2023

ok i just looked into this i think we want to add a config.json file and

https://github.com/tcort/markdown-link-check#config-file-format and use this

"aliveStatusCodes": [200, 206]

to ignore whatever codes are being problematic. so in this case 403 codes i think we can mark as "alive" so the build doesn't error our.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants