Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JOSS DOI to review issue metadata #130

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

isabelizimm
Copy link
Contributor

For editorial review triage, let's add in JOSS DOI as a metadata field to explicitly track the amazing pyOpenSci packages that are being published 🥳

@isabelizimm
Copy link
Contributor Author

Hmm...the linter is saying https://opensource.org/licenses/ is a dead link, but I am able to connect to the webpage. @lwasser do you know what that is all about? 😅

@cmarmo
Copy link
Member

cmarmo commented Sep 7, 2023

Hi @isabelizimm , perhaps it was just a temporary 'black-out' of the site... do you mind pushing an empty commit or closing/reopening the pull request to trig the check again?
Thanks for your triaging work, I think I'm finally back too... :)

@isabelizimm isabelizimm closed this Sep 7, 2023
@isabelizimm isabelizimm reopened this Sep 7, 2023
@isabelizimm
Copy link
Contributor Author

Welcome back @cmarmo!! It looks like the OSI site is still failing. This seems to be a failure in other PRs that have been merged, so I think this is okay to review+merge. I'll open an issue so others are aware that this is a known issue!

@lwasser
Copy link
Member

lwasser commented Sep 11, 2023

i left a note here

i think we just want to tell ci to ignore 403 errors. we've had to do this in our other guidebook repos. Thank you both for working on this!! :)

@lwasser
Copy link
Member

lwasser commented Oct 3, 2023

ok i just merged the PR with the URL fix! i suspect @isabelizimm if you can rebase against the main branch, this PR will now pass!! 🎉

@isabelizimm
Copy link
Contributor Author

ok i just merged the PR with the URL fix! i suspect @isabelizimm if you can rebase against the main branch, this PR will now pass!! 🎉

You are correct! Merging without review since it's a small, non-code change (can always update the template again if needed)!

@isabelizimm isabelizimm merged commit 62bd900 into pyOpenSci:main Oct 16, 2023
2 checks passed
@isabelizimm isabelizimm deleted the update-metadata branch October 16, 2023 13:36
@lwasser
Copy link
Member

lwasser commented Oct 16, 2023

thanks so much for this @isabelizimm !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants