python_api: improve approx assert message on mappings with only extra elements #13723
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
bluetech
force-pushed
the
approx-mapping-len
branch
from
5be188c to
9ef4cd0
Compare
| if len(self.expected) != len(other_side): | ||
| return [ | ||
| "Impossible to compare mappings with different sizes.", | ||
| f"Lengths: {len(self.expected)} and {len(other_side)}", |
There was a problem hiding this comment.
If the bigger length is small (<10) and (or? Calling str might be costly) the Str representation of both is small (fit in max truncation) we might want to show the two mappings directly ?
There was a problem hiding this comment.
The full message does include a snippet:
def test_it():
> assert pytest.approx({"a": 1, "b": 2}) == {"a": 1, "b": 2, "c": 3}
E AssertionError: assert approx({'a': ... 2 ± 2.0e-06}) == {'a': 1, 'b': 2, 'c': 3}
E
E Impossible to compare mappings with different sizes.
E Lengths: 2 and 3
x.py:4: AssertionError
nicoddemus
approved these changes
Sep 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13722