drop 3.7, add mypy test, bump reqs, etc #189
Conversation
…t in CI. * Adds loose mypy run to Makefile & CI * Adds some type annotations * Adds 3.13-dev test run. It currently fails, but will pass once trio and cffi push new releases. * Adds blurb to readme on status of the project. * Bump package versions in requirements-dev.txt and requirements-dev-full.txt * Adds small tests to slightly bump code coverage
.github/workflows/ci.yml
Outdated
| python-version: ['3.12-dev'] | ||
| python-version: ['3.13-dev'] |
There was a problem hiding this comment.
Adds 3.13-dev test run. It currently fails, but will pass once trio and cffi push new releases.
I'd prefer to leave it at 3.12 for now so that all CI passes, and add a TODO pending the trio/cffi releases.
There was a problem hiding this comment.
I'll open an issue if trio/cffi have not released by the time #188 is finalized & merged
jakkdl
changed the title
| @@ -4,4 +4,5 @@ pip-tools>=5.5.0 | |||
| pytest>=4.6 | |||
| pytest-cov | |||
| pytest-trio>=0.5.0 | |||
| trio<0.25 | |||
There was a problem hiding this comment.
technically this constraint should probably be in setup.py
but I suppose it gets resolved if we get the upcoming PR worked out
There was a problem hiding this comment.
well, the package itself isn't non-functioning - it works plenty well with trio==0.25, and if you specify a value to strict_exception_groups there is no change in functionality at all. I could even modify the tests in this PR to pass on both <0.25 and >=0.25 and not have the requirement at all.
But I don't see much reason to push a release without #188 anyhow, so I think it's pretty moot
Split out from #188 with a
--patchcheckout. This does destroy the commit history, so I might need to rewrite the history in #188 to avoid conflicts.Adds 3.13-dev test run. It currently fails, but will pass once trio and cffi push new releases.