-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop 3.7, add mypy test, bump reqs, etc #189
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,4 +4,5 @@ pip-tools>=5.5.0 | |
pytest>=4.6 | ||
pytest-cov | ||
pytest-trio>=0.5.0 | ||
trio<0.25 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. technically this constraint should probably be in setup.py but I suppose it gets resolved if we get the upcoming PR worked out There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. well, the package itself isn't non-functioning - it works plenty well with trio==0.25, and if you specify a value to But I don't see much reason to push a release without #188 anyhow, so I think it's pretty moot |
||
trustme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to leave it at 3.12 for now so that all CI passes, and add a TODO pending the trio/cffi releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll open an issue if trio/cffi have not released by the time #188 is finalized & merged