-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-123843: change _datetimemodule.c & datetimetest.py zope refs to archive #123844
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Please remove the |
@Eclips4 done, thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having looked at the two links, I'm not sure that they add anything valuable beyond historic interest from 20 years ago -- I've opened #123846 as a sketch of a different approach to remove the links. I tried to add them as review suggestions but GH's interface made it too confusing, sorry.
A
I add DO-NOT-MERGE because I am perhaps 90% sure that Turner's alternative PR should be merged instead. But I am not quite sure enough to just do it. |
@AA-Turner @terryjreedy Tbh I agree removing the links is better, I would even propose that links be removed from comments in general. Closing in favor of #123846 |
Resolves the issue by replacing broken references with archived versions of the canonical zope pages