Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-123843: change _datetimemodule.c & datetimetest.py zope refs to archive #123844

Closed
wants to merge 1 commit into from

Conversation

otkd
Copy link
Contributor

@otkd otkd commented Sep 8, 2024

Resolves the issue by replacing broken references with archived versions of the canonical zope pages

Copy link

cpython-cla-bot bot commented Sep 8, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Sep 8, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@picnixz picnixz changed the title gh-123843 change _datetimemodule.c & datetimetest.py zope refs to archive gh-123843: change _datetimemodule.c & datetimetest.py zope refs to archive Sep 8, 2024
@Eclips4 Eclips4 added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Sep 8, 2024
@Eclips4
Copy link
Member

Eclips4 commented Sep 8, 2024

Please remove the NEWS entry, it's not needed here.

@otkd
Copy link
Contributor Author

otkd commented Sep 8, 2024

Please remove the NEWS entry, it's not needed here.

@Eclips4 done, thank you

Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having looked at the two links, I'm not sure that they add anything valuable beyond historic interest from 20 years ago -- I've opened #123846 as a sketch of a different approach to remove the links. I tried to add them as review suggestions but GH's interface made it too confusing, sorry.

A

@terryjreedy
Copy link
Member

I add DO-NOT-MERGE because I am perhaps 90% sure that Turner's alternative PR should be merged instead. But I am not quite sure enough to just do it.

@otkd
Copy link
Contributor Author

otkd commented Sep 8, 2024

@AA-Turner @terryjreedy Tbh I agree removing the links is better, I would even propose that links be removed from comments in general.

Closing in favor of #123846

@otkd otkd closed this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants