Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-123843: Remove broken links to the Zope DateTimeWiki #123846

Merged
merged 2 commits into from
Sep 9, 2024
Merged

gh-123843: Remove broken links to the Zope DateTimeWiki #123846

merged 2 commits into from
Sep 9, 2024

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Sep 8, 2024 •
edited by bedevere-app bot
Loading

@AA-Turner AA-Turner mentioned this pull request Sep 8, 2024
Closed
@Eclips4
Copy link
Member

Eclips4 commented Sep 8, 2024

If we're talking about "Are these links really useful anymore?" I would say "No, let's remove them".

So I'm in favor of removing them.

otkd
otkd suggested changes Sep 8, 2024
View reviewed changes
Copy link
Contributor

@otkd otkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change for clarity and resolved link

Lib/datetime.py Outdated Show resolved Hide resolved
Lib/datetime.py Outdated Show resolved Hide resolved
@AA-Turner @otkd
Wordsmithing
c840640 
Co-authored-by: Conrad Bhuiyan-Volkoff <[email protected]>
@AA-Turner AA-Turner requested a review from otkd September 8, 2024 20:16
otkd
otkd approved these changes Sep 8, 2024
View reviewed changes
Copy link
Contributor

@otkd otkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@terryjreedy
Copy link
Member

Looks good; nothing to add.

@AA-Turner AA-Turner merged commit 93b61bc into python:main Sep 9, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otkd otkd otkd approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AA-Turner @Eclips4 @terryjreedy @otkd