Skip to content

gh-116946: fully implement GC protocol for random.Random #138341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-116946: fully implement GC protocol for random.Random #138341

wants to merge 1 commit into from
+11 −6

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Sep 1, 2025 •
edited by bedevere-app bot
Loading

On main the following leaks:

$ ./python -X showrefcount -c 'import _random; s = _random.Random(); t = type(s); t._random = s'
[42 refs, 26 blocks]

@picnixz picnixz requested a review from rhettinger as a code owner September 1, 2025 13:19
@bedevere-app bedevere-app bot mentioned this pull request Sep 1, 2025
Open
ZeroIntensity
ZeroIntensity approved these changes Sep 1, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one idea.

@serhiy-storchaka
Copy link
Member

Wait, why is _random.Random mutable?

@ZeroIntensity
Copy link
Member

Probably because it would break code to change that.

@serhiy-storchaka
Copy link
Member

It became mutable in 3.9. I think this is a bug.

@picnixz
Copy link
Member Author

picnixz commented Sep 1, 2025

It became mutable in 3.9. I think this is a bug.

I was also surprised but I just didn't want to break stuff here.

@kumaraditya303
Copy link
Contributor

It became mutable in 3.9. I think this is a bug.

Yes, I think adding IMMUTABLE flag was missed while conversion, it shouldn't be a mutable type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees
No one assigned
Labels
awaiting merge skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@picnixz @serhiy-storchaka @ZeroIntensity @kumaraditya303