Skip to content

gh-116946: add Py_TPFLAGS_IMMUTABLETYPE to _random.Random #138341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2025
Merged

gh-116946: add Py_TPFLAGS_IMMUTABLETYPE to _random.Random #138341

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f6c5aa
fully implement GC protocol for `random.Random`
picnixz Sep 1, 2025
488be06
make random.Random immutable instead of supporting full GC
picnixz Sep 2, 2025
2068b50
blurb
picnixz Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions Modules/_randommodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,12 @@ random_init(PyObject *self, PyObject *args, PyObject *kwds)
return random_seed(RandomObject_CAST(self), arg);
}

static int
random_traverse(PyObject *op, visitproc visit, void *arg)
{
Py_VISIT(Py_TYPE(op));
return 0;
}

static PyMethodDef random_methods[] = {
_RANDOM_RANDOM_RANDOM_METHODDEF
Expand All @@ -590,16 +596,15 @@ static PyType_Slot Random_Type_slots[] = {
{Py_tp_methods, random_methods},
{Py_tp_new, PyType_GenericNew},
{Py_tp_init, random_init},
{Py_tp_free, PyObject_Free},
{Py_tp_traverse, random_traverse},
{0, 0},
};

static PyType_Spec Random_Type_spec = {
"_random.Random",
sizeof(RandomObject),
0,
Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE,
Random_Type_slots
.name = "_random.Random",
.basicsize = sizeof(RandomObject),
.flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE | Py_TPFLAGS_HAVE_GC,
.slots = Random_Type_slots
};

PyDoc_STRVAR(module_doc,
Expand Down
Loading