[1/2] Wean off of PYBIND in favor of torch.ops.load_library #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1275
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 2ea7b4c with merge base f96e5ec ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
janeyx99
added a commit
that referenced
this pull request
Nov 12, 2024
ghstack-source-id: 581221e576fde7f1744477c06027278fed229b89 Pull Request resolved: #1275
facebook-github-bot
added
the
CLA Signed
janeyx99
added
the
topic: for developers
janeyx99
changed the title
Pave the path for python agnostic ao by removing depending on PYBIND (which is not python agnostic). This PR should have no failures. The next PR will be targeting the wheel process to only output one wheel for every python version. [ghstack-poisoned]
janeyx99
added a commit
that referenced
this pull request
Nov 12, 2024
ghstack-source-id: 16299c82626a4673d4130e0b57c51c4dfdc79ab7 Pull Request resolved: #1275
Pave the path for python agnostic ao by removing depending on PYBIND (which is not python agnostic). Concretely, what happened this PR? - no more PYBIND, so no more init.cpp - for all non-CUDA platforms, ao no longer has custom cpp extensions, and thus ao is a pure python lib - so we skip auditwheel (which is used for when the platform is linux) for all non-cuda wheel builds - no more PYBIND also means no more torchao._C, which we're replacing with a load_library call This PR should have no failures. The next PR will be targeting the wheel process to only output one wheel for every python version. [ghstack-poisoned]
janeyx99
added a commit
that referenced
this pull request
Nov 12, 2024
ghstack-source-id: 04eb397def723b4cd24e1df9d0bb791988eadfaa Pull Request resolved: #1275
janeyx99
changed the title
Pave the path for python agnostic ao by removing depending on PYBIND (which is not python agnostic). Concretely, what happened this PR? - no more PYBIND, so no more init.cpp - for all non-CUDA platforms, ao no longer has custom cpp extensions, and thus ao is a pure python lib - so we skip auditwheel (which is used for when the platform is linux) for all non-cuda wheel builds - no more PYBIND also means no more torchao._C, which we're replacing with a load_library call This PR should have no failures. The next PR will be targeting the wheel process to only output one wheel for every python version. [ghstack-poisoned]
janeyx99
added a commit
that referenced
this pull request
Nov 12, 2024
ghstack-source-id: f08db0ecc13a1e1aa40ab87d24fba641844b84e5 Pull Request resolved: #1275
huydhn
reviewed
Nov 12, 2024
| @@ -110,6 +110,9 @@ def get_extensions(): | |||
| if use_cuda: | |||
| sources += cuda_sources | |||
|
|
|||
| if len(sources) == 0: | |||
There was a problem hiding this comment.
if not sources sounds more pythonic?
There was a problem hiding this comment.
ehhhh it looks less readable to me
janeyx99
changed the title
janeyx99
changed the title
|
Closing in favor of #1276 as that one passes all CI. It looks like Build M1 Wheels does not work with ghstack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pave the path for python agnostic ao by removing depending on PYBIND (which is not python agnostic).
Concretely, what happened this PR?
This PR should have no failures. The next PR will be targeting the wheel process to only output one wheel for every python version.
Stack from ghstack (oldest at bottom):