[1/2] Wean off of PYBIND in favor of torch.ops.load_library #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1276
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit acd19e0 with merge base f96e5ec ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
janeyx99
added
the
topic: for developers
msaroufim
approved these changes
Nov 13, 2024
| WHEEL_NAME=$(ls dist/) | ||
| # Prepare manywheel, only for CUDA. | ||
| # The wheel is a pure python wheel for other platforms. | ||
| if [[ "$CU_VERSION" == cu* ]]; then |
There was a problem hiding this comment.
No, but it looks like the current .cu files are not built for rocm based on the use_cuda here https://github.com/pytorch/ao/blob/main/setup.py#L64
There was a problem hiding this comment.
Ok! heads up to @petrex who has been working on adding custom hip kernel support
sunjiweiswift
pushed a commit
to sunjiweiswift/ao
that referenced
this pull request
Nov 25, 2024
…1276) Wean ao off of PYBIND [part 1]
This was referenced Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The no ghstack version of #1275 to see if the mac tests pass (they do).
Pave the path for python agnostic ao by removing depending on PYBIND (which is not python agnostic).
Concretely, what happened this PR?
This PR should have no failures. The next PR will be targeting the wheel process to only output one wheel for every python version. If you're curious, the next PR looks like #1277