Skip to content

Conversation

AdrianLundell
Copy link
Collaborator

@AdrianLundell AdrianLundell commented Sep 22, 2025

This removes a reference to the binary tree in the install tree.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Signed-off-by: Adrian Lundell <[email protected]>
Change-Id: I3217fbfa005b317080ca030774153002a5901546
@AdrianLundell AdrianLundell added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Sep 22, 2025
Copy link

pytorch-bot bot commented Sep 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14465

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 8a0c98d with merge base 5ae40f1 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 22, 2025
@AdrianLundell AdrianLundell added the release notes: none Do not include this in the release notes label Sep 23, 2025
@AdrianLundell
Copy link
Collaborator Author

Fails does not look related

TARGETS extension_runner_util
EXPORT ExecuTorchTargets
DESTINATION ${CMAKE_BINARY_DIR}/lib
DESTINATION lib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CMAKE_BINARY_DIR == CMAKE_INSTALL_PREFIX?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intention is to install the lib in CMAKE_INSTALL_PREFIX instead of the binary dir, if someone has a reason for placing it there they can make sure to set CMAKE_BINARY_DIR == CMAKE_INSTALL_PREFIX but I don't see why it would be a requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants