-
Notifications
You must be signed in to change notification settings - Fork 670
Make extension_runner_util install relative #14465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Adrian Lundell <[email protected]> Change-Id: I3217fbfa005b317080ca030774153002a5901546
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14465
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 8a0c98d with merge base 5ae40f1 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Fails does not look related |
TARGETS extension_runner_util | ||
EXPORT ExecuTorchTargets | ||
DESTINATION ${CMAKE_BINARY_DIR}/lib | ||
DESTINATION lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming CMAKE_BINARY_DIR == CMAKE_INSTALL_PREFIX?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My intention is to install the lib in CMAKE_INSTALL_PREFIX instead of the binary dir, if someone has a reason for placing it there they can make sure to set CMAKE_BINARY_DIR == CMAKE_INSTALL_PREFIX but I don't see why it would be a requirement.
This removes a reference to the binary tree in the install tree.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218