Skip to content

Make extension_runner_util install relative #14465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make extension_runner_util install relative #14465

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a0c98d
Make extension_runner_util install relative
AdrianLundell Sep 12, 2025
ec6a7dc
Merge branch 'main' into change-1109310
zingo Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion extension/runner_util/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Copyright (c) Meta Platforms, Inc. and affiliates.
# All rights reserved.
# Copyright 2025 Arm Limited and/or its affiliates.
#
# This source code is licensed under the BSD-style license found in the
# LICENSE file in the root directory of this source tree.
Expand Down Expand Up @@ -28,7 +29,7 @@ target_compile_options(extension_runner_util PUBLIC ${_common_compile_options})
install(
TARGETS extension_runner_util
EXPORT ExecuTorchTargets
DESTINATION ${CMAKE_BINARY_DIR}/lib
DESTINATION lib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CMAKE_BINARY_DIR == CMAKE_INSTALL_PREFIX?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intention is to install the lib in CMAKE_INSTALL_PREFIX instead of the binary dir, if someone has a reason for placing it there they can make sure to set CMAKE_BINARY_DIR == CMAKE_INSTALL_PREFIX but I don't see why it would be a requirement.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, but if the CI is green then I guess this is OK. Let me add trunk just to be sure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this?

executorch/examples/cadence/CMakeLists.txt

Line 94 in b3f3111

"${CMAKE_CURRENT_LIST_DIR}/../../cmake-out/extension/runner_util/libextension_runner_util.a"

Copy link
Collaborator Author

@AdrianLundell AdrianLundell Sep 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should only affect the install tree so if you want to use the build tree library instead that should still be in the same place, in the Arm example we use FindPackage to avoid direct paths and that works well.

The reason why we want to make this change is to make it possible to move around the install tree without braking anything, for example to help parallelizing testing.

INCLUDES
DESTINATION ${_common_include_directories}
)
Expand Down
Loading