Fix MODEL_CONVERTER_LIB_DIR path resolution for VGF tests (#20907)#20907
Open
psiddh wants to merge 1 commit into
Open
Fix MODEL_CONVERTER_LIB_DIR path resolution for VGF tests (#20907)#20907psiddh wants to merge 1 commit into
psiddh wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20907
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 89e982e with merge base 39f4355 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D111819484. |
This PR needs a
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Buck2 test environment for Arm VGF tests to make MODEL_CONVERTER_LIB_DIR resolve reliably in sandboxed test execution, avoiding path construction via string concatenation after $(location) expansion.
Changes:
- Replace
$(location ...:linux-x86_64)/host-linux-x64with a direct$(location ...:host-linux-x64-libs)reference forMODEL_CONVERTER_LIB_DIR.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
meta-codesync
Bot
changed the title
psiddh
added a commit
to psiddh/executorch
that referenced
this pull request
Jul 14, 2026
) Summary: After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests (mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed() returns False on sandcastle. Root cause: MODEL_CONVERTER_LIB_DIR was set to $(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64 which relies on string concatenation after $(location) expansion. In Buck2 test sandboxes, this pattern can produce an invalid path because the export_file artifact reference may not expose subdirectories properly. Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory and reference it directly with $(location), eliminating the string concatenation. Impact: −160 SKIPPING tests Reviewed By: rascani Differential Revision: D111819484
psiddh
force-pushed
the
export-D111819484
branch
from
July 14, 2026 15:04
d0caa12 to
b075bb8
Compare
rascani
approved these changes
Jul 14, 2026
psiddh
added a commit
to psiddh/executorch
that referenced
this pull request
Jul 15, 2026
) Summary: After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests (mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed() returns False on sandcastle. Root cause: MODEL_CONVERTER_LIB_DIR was set to $(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64 which relies on string concatenation after $(location) expansion. In Buck2 test sandboxes, this pattern can produce an invalid path because the export_file artifact reference may not expose subdirectories properly. Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory and reference it directly with $(location), eliminating the string concatenation. Impact: −160 SKIPPING tests Reviewed By: rascani Differential Revision: D111819484
psiddh
force-pushed
the
export-D111819484
branch
from
July 15, 2026 05:43
6bdaa71 to
728c92b
Compare
psiddh
added a commit
to psiddh/executorch
that referenced
this pull request
Jul 15, 2026
) Summary: After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests (mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed() returns False on sandcastle. Root cause: MODEL_CONVERTER_LIB_DIR was set to $(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64 which relies on string concatenation after $(location) expansion. In Buck2 test sandboxes, this pattern can produce an invalid path because the export_file artifact reference may not expose subdirectories properly. Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory and reference it directly with $(location), eliminating the string concatenation. Impact: −160 SKIPPING tests Reviewed By: rascani Differential Revision: D111819484
psiddh
force-pushed
the
export-D111819484
branch
from
July 15, 2026 05:51
728c92b to
f496e8a
Compare
psiddh
added a commit
to psiddh/executorch
that referenced
this pull request
Jul 15, 2026
) Summary: Pull Request resolved: pytorch#20907 After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests (mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed() returns False on sandcastle. Root cause: MODEL_CONVERTER_LIB_DIR was set to $(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64 which relies on string concatenation after $(location) expansion. In Buck2 test sandboxes, this pattern can produce an invalid path because the export_file artifact reference may not expose subdirectories properly. Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory and reference it directly with $(location), eliminating the string concatenation. Impact: −160 SKIPPING tests Reviewed By: rascani Differential Revision: D111819484
psiddh
force-pushed
the
export-D111819484
branch
from
July 15, 2026 05:52
f496e8a to
82949df
Compare
psiddh
added a commit
to psiddh/executorch
that referenced
this pull request
Jul 15, 2026
) Summary: After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests (mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed() returns False on sandcastle. Root cause: MODEL_CONVERTER_LIB_DIR was set to $(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64 which relies on string concatenation after $(location) expansion. In Buck2 test sandboxes, this pattern can produce an invalid path because the export_file artifact reference may not expose subdirectories properly. Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory and reference it directly with $(location), eliminating the string concatenation. Impact: −160 SKIPPING tests Reviewed By: rascani Differential Revision: D111819484
psiddh
force-pushed
the
export-D111819484
branch
from
July 15, 2026 05:53
82949df to
a84ed6f
Compare
psiddh
added a commit
to psiddh/executorch
that referenced
this pull request
Jul 18, 2026
) Summary: After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests (mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed() returns False on sandcastle. Root cause: MODEL_CONVERTER_LIB_DIR was set to $(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64 which relies on string concatenation after $(location) expansion. In Buck2 test sandboxes, this pattern can produce an invalid path because the export_file artifact reference may not expose subdirectories properly. Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory and reference it directly with $(location), eliminating the string concatenation. Impact: −160 SKIPPING tests Reviewed By: rascani Differential Revision: D111819484
psiddh
force-pushed
the
export-D111819484
branch
from
July 18, 2026 08:12
a84ed6f to
8c22c13
Compare
psiddh
added a commit
to psiddh/executorch
that referenced
this pull request
Jul 19, 2026
) Summary: After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests (mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed() returns False on sandcastle. Root cause: MODEL_CONVERTER_LIB_DIR was set to $(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64 which relies on string concatenation after $(location) expansion. In Buck2 test sandboxes, this pattern can produce an invalid path because the export_file artifact reference may not expose subdirectories properly. Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory and reference it directly with $(location), eliminating the string concatenation. Impact: −160 SKIPPING tests Reviewed By: rascani Differential Revision: D111819484
psiddh
force-pushed
the
export-D111819484
branch
from
July 19, 2026 06:42
8c22c13 to
dfbc118
Compare
) Summary: After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests (mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed() returns False on sandcastle. Root cause: MODEL_CONVERTER_LIB_DIR was set to $(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64 which relies on string concatenation after $(location) expansion. In Buck2 test sandboxes, this pattern can produce an invalid path because the export_file artifact reference may not expose subdirectories properly. Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory and reference it directly with $(location), eliminating the string concatenation. Impact: −160 SKIPPING tests Reviewed By: rascani Differential Revision: D111819484
psiddh
force-pushed
the
export-D111819484
branch
from
July 19, 2026 06:44
dfbc118 to
89e982e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
After bumping model-converter to v0.9.0 (D109721412), ~160 ARM VGF tests
(mxfp_linear, mxfp_conv2d) started SKIPPING because model_converter_installed()
returns False on sandcastle.
Root cause: MODEL_CONVERTER_LIB_DIR was set to
$(location fbsource//third-party/nvidia-nsight-systems:linux-x86_64)/host-linux-x64
which relies on string concatenation after $(location) expansion. In Buck2 test
sandboxes, this pattern can produce an invalid path because the export_file
artifact reference may not expose subdirectories properly.
Fix: Create a dedicated export_file target for the host-linux-x64 subdirectory
and reference it directly with $(location), eliminating the string concatenation.
Impact: −160 SKIPPING tests
Reviewed By: rascani
Differential Revision: D111819484