Add suspend/resume to execute#20983
Conversation
Summary: Neutron driver provides suspend/resume functions. This PR adds them to the backend, as close to execute call as possible, gated behind an ifdef so implementations can opt-in. Differential Revision: D112413599
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20983
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 7f4d949 with merge base e51f1a9 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112413599. |
This PR needs a
|
digantdesai
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
@JakeStevens you did not update the CMakeLists.txt just the buck system. But feel free to proceed. I will update the CMakeLists afterwards. |
| et_timestamp_t stop_ticks = ::executorch::runtime::pal_current_ticks(); | ||
| #endif | ||
|
|
||
| #ifdef NEUTRON_NPU_POWER_GATING |
There was a problem hiding this comment.
Do you need to enable/disable the clock gating feature?
There was a problem hiding this comment.
Maybe @jirioc can confirm? I did not explicitly, I can look to see if it already was in the system somehow though
I explicitly only updated BUCK, to keep it default OFF for the main, open source entry point. We can update the CMake too if you want to move to default ON for the main build |
Summary:
Neutron driver provides suspend/resume functions.
This PR adds them to the backend, as close to execute call as possible, gated behind an ifdef so implementations can opt-in.
Differential Revision: D112413599