Skip to content

Add suspend/resume to execute (#20983) #20983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meta-codesync merged 1 commit into from
Jul 20, 2026
+28 −6
Merged

Add suspend/resume to execute (#20983) #20983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions backends/nxp/runtime/NeutronBackend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,25 +523,45 @@ class NeutronBackend final : public PyTorchBackendInterface {
}
}

// Resume (clock-ungate) the NPU immediately before inference and suspend it
// again immediately after, so its clock only runs during compute
#ifdef NEUTRON_NPU_POWER_GATING
NeutronError resumeRC = neutronResume();
if (resumeRC != ENONE) {
ET_LOG(Error, "neutronResume failed with error code %ld", resumeRC);
return Error::InvalidProgram;
}
#endif

#ifdef ET_EVENT_TRACER_ENABLED
// Save ticks before neutron compute to measure how much time profiling dump
// takes
et_timestamp_t start_ticks = ::executorch::runtime::pal_current_ticks();
#endif
// Run neutron compute.
NeutronError neutronRC = neutronRunBlocking(cfg->nmh, &cfg->dcfg);
#ifdef ET_EVENT_TRACER_ENABLED
// Save ticks after neutron compute to measure how much time profiling dump
// takes
et_timestamp_t stop_ticks = ::executorch::runtime::pal_current_ticks();
#endif

#ifdef NEUTRON_NPU_POWER_GATING

@robert-kalmar robert-kalmar Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to enable/disable the clock gating feature?

@JakeStevens JakeStevens Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @jirioc can confirm? I did not explicitly, I can look to see if it already was in the system somehow though

// Suspend (clock-gate) the NPU again regardless of the run result; a failed
// suspend only wastes power, so it must not fail the inference.
NeutronError suspendRC = neutronSuspend();
if (suspendRC != ENONE) {
ET_LOG(Error, "neutronSuspend failed with error code %ld", suspendRC);
}
#endif

if (neutronRC != ENONE) {
ET_LOG(
Error,
"Neutron model evaluation failed with error code %ld",
neutronRC);
return Error::InvalidProgram;
}
#ifdef ET_EVENT_TRACER_ENABLED
// Save ticks after neutron compute to measure how much time profiling dump
// takes
et_timestamp_t stop_ticks = ::executorch::runtime::pal_current_ticks();
#endif

// Transpose outputs.
for (int i = 0; i < cfg->numOutputs; i++) {
Expand Down
4 changes: 3 additions & 1 deletion backends/nxp/runtime/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ def define_common_targets():
],
link_whole = True,
# Constructor needed for backend registration.
compiler_flags = ["-Wno-global-constructors", "-fno-rtti", "-DNO_HEAP_USAGE"],
# NEUTRON_NPU_POWER_GATING clock-gates the NPU around each inference
# (neutronResume/neutronSuspend in NeutronBackend.cpp).
compiler_flags = ["-Wno-global-constructors", "-fno-rtti", "-DNO_HEAP_USAGE", "-DNEUTRON_NPU_POWER_GATING"],
labels = [ci.skip_target()],
visibility = ["PUBLIC"],
deps = [
Expand Down
Loading