Skip to content

Adding HiFi5 DSP support in Cadence backend - #21497

Open
dijopaul wants to merge 3 commits into
pytorch:mainfrom
foss-xtensa:main
Open

Adding HiFi5 DSP support in Cadence backend#21497
dijopaul wants to merge 3 commits into
pytorch:mainfrom
foss-xtensa:main

Conversation

@dijopaul

Copy link
Copy Markdown
Contributor

Summary

Add support for HiFi5 DSP build in Cadence backend
Changes are in backend/cadence folder only

Test plan

Verified the build and run locally

Changes are in backend/cadence only
@pytorch-bot

pytorch-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21497

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 1 Unclassified Failure

As of commit e0158e1 with merge base 761c64c (image):

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

  • pull / test-coreml-bc-macos (macos-m1-stable) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]API rate limit exceeded for installation. If you reach out to GitHub Support for help, please include the request ID E452:33F279:132AD33:3FCAE44:6A72F9D8 and timestamp 2026-08-05 08:52:40 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) - https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api#rate-limiting

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 30, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 30, 2026

Copy link
Copy Markdown

CLA Not Signed

Comment thread backends/cadence/CMakeLists.txt Outdated
Comment thread backends/cadence/install_requirements.sh Outdated
@dijopaul

Copy link
Copy Markdown
Contributor Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot Bot added the release notes: none Do not include this in the release notes label Jul 31, 2026
)
set(CMAKE_CXX_FLAGS_INIT
"-stdlib=libc++ -mtext-section-literals -mlongcalls -DET_ENABLE_ENUM_STRINGS=0"
"-stdlib=libc++ -mtext-section-literals -mlongcalls -DET_ENABLE_ENUM_STRINGS=0 -O3 -mcoproc -LNO:simd -ffunction-sections -fsigned-char -INLINE:requested -fno-zero-initialized-in-bss -fmessage-length=0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can that change break something on older toolchains? Or all of those flags are defined properly

@dijopaul dijopaul Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't break someting and its well defined in all toolchain and cores. But here we are giving -O3 by default irrespective of Debug or Release build. We thought of minimizing changes to backend cmakelist for now. If we can handle it at the topmost cmakelist it would be better.

@mcremon-meta

Copy link
Copy Markdown
Contributor

@aliafzal can you take a look?

@dijopaul you need to sign the EasyCLA to get rid of the blocker, let me know if you run into any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants