Skip to content

Adding HiFi5 DSP support in Cadence backend #21497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dijopaul wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adding HiFi5 DSP support in Cadence backend #21497

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70c70f2
Adding HiFi5 support
dijopaul Jul 30, 2026
01ee163
Add HiFi5 support in Cadence backend - fix review comments
dijopaul Jul 31, 2026
e0158e1
Merge branch 'main' into main
dijopaul Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions backends/cadence/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,18 @@ if(EXECUTORCH_NNLIB_OPT)
${EXECUTORCH_ROOT}/runtime/core/portable_type/c10
)
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${TARGET_DIR}/kernels)
elseif(EXECUTORCH_HIFI_CORE STREQUAL "hifi1" OR EXECUTORCH_HIFI_CORE STREQUAL
"hifi4"
)
add_compile_definitions(CORE_HIFI5=0)
set(TARGET_DIR hifi)
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${TARGET_DIR}/third-party/nnlib)
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${TARGET_DIR}/kernels)
Comment thread
dijopaul marked this conversation as resolved.
Outdated
elseif(EXECUTORCH_HIFI_CORE STREQUAL "hifi5")
add_compile_definitions(CORE_HIFI5=1)
set(TARGET_DIR hifi)
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${TARGET_DIR}/third-party/nnlib)
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${TARGET_DIR}/kernels)
elseif(EXECUTORCH_FUSION_G3_OPT)
set(TARGET_DIR fusion_g3)
add_subdirectory(
Expand Down
4 changes: 2 additions & 2 deletions backends/cadence/cadence.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ set(CMAKE_C_COMPILER ${TOOLCHAIN_HOME}/bin/${CROSS_COMPILE_TARGET}-clang)
set(CMAKE_CXX_COMPILER ${TOOLCHAIN_HOME}/bin/${CROSS_COMPILE_TARGET}-clang++)

set(CMAKE_C_FLAGS_INIT
"-stdlib=libc++ -mtext-section-literals -mlongcalls -DET_ENABLE_ENUM_STRINGS=0"
"-stdlib=libc++ -mtext-section-literals -mlongcalls -DET_ENABLE_ENUM_STRINGS=0 -O3 -mcoproc -LNO:simd -ffunction-sections -fsigned-char -INLINE:requested -fno-zero-initialized-in-bss -fmessage-length=0"
)
set(CMAKE_CXX_FLAGS_INIT
"-stdlib=libc++ -mtext-section-literals -mlongcalls -DET_ENABLE_ENUM_STRINGS=0"
"-stdlib=libc++ -mtext-section-literals -mlongcalls -DET_ENABLE_ENUM_STRINGS=0 -O3 -mcoproc -LNO:simd -ffunction-sections -fsigned-char -INLINE:requested -fno-zero-initialized-in-bss -fmessage-length=0"

@mcremon-meta mcremon-meta Aug 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can that change break something on older toolchains? Or all of those flags are defined properly

@dijopaul dijopaul Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't break someting and its well defined in all toolchain and cores. But here we are giving -O3 by default irrespective of Debug or Release build. We thought of minimizing changes to backend cmakelist for now. If we can handle it at the topmost cmakelist it would be better.

)
# workaround for larger compilation time
set(CMAKE_CXX_FLAGS_INIT "${CMAKE_CXX_FLAGS_INIT} -fno-strict-aliasing")
Expand Down
16 changes: 12 additions & 4 deletions backends/cadence/hifi/kernels/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,22 @@ set(_common_include_directories
${EXECUTORCH_ROOT}/.. ${EXECUTORCH_ROOT}/runtime/core/portable_type/c10
)

if(EXECUTORCH_HIFI_CORE STREQUAL "hifi5")
set(NNLIB_DIR_NAME "nnlib-hifi5")
set(NNLIB_ARCH_DIR "hifi5")
else()
set(NNLIB_DIR_NAME "nnlib-hifi4")
set(NNLIB_ARCH_DIR "hifi4")
endif()

target_include_directories(
cadence_kernels
PUBLIC
.
${EXECUTORCH_ROOT}/backends/cadence/hifi/third-party/nnlib/nnlib-hifi4/xa_nnlib/algo/common/include/
${EXECUTORCH_ROOT}/backends/cadence/hifi/third-party/nnlib/nnlib-hifi4/xa_nnlib/include/nnlib
${EXECUTORCH_ROOT}/backends/cadence/hifi/third-party/nnlib/nnlib-hifi4/xa_nnlib/include
${EXECUTORCH_ROOT}/backends/cadence/hifi/third-party/nnlib/nnlib-hifi4/xa_nnlib/algo/ndsp/hifi4/include/
${EXECUTORCH_ROOT}/backends/cadence/hifi/third-party/nnlib/${NNLIB_DIR_NAME}/xa_nnlib/algo/common/include/
${EXECUTORCH_ROOT}/backends/cadence/hifi/third-party/nnlib/${NNLIB_DIR_NAME}/xa_nnlib/include/nnlib
${EXECUTORCH_ROOT}/backends/cadence/hifi/third-party/nnlib/${NNLIB_DIR_NAME}/xa_nnlib/include
${EXECUTORCH_ROOT}/backends/cadence/hifi/third-party/nnlib/${NNLIB_DIR_NAME}/xa_nnlib/algo/ndsp/${NNLIB_ARCH_DIR}/include/
${_common_include_directories}
)

Expand Down
5 changes: 5 additions & 0 deletions backends/cadence/hifi/kernels/kernels.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@

#include <executorch/backends/cadence/hifi/kernels/kernels.h>
#include <xa_nnlib_common.h>

#if CORE_HIFI5
#include <xa_nnlib_common_macros_hifi5.h>
#else
#include <xa_nnlib_common_macros.h>
#endif

namespace impl {
namespace HiFi {
Expand Down
8 changes: 7 additions & 1 deletion backends/cadence/hifi/third-party/nnlib/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
cmake_minimum_required(VERSION 3.10.0)
project(cadence_nnlib)

if(EXECUTORCH_HIFI_CORE STREQUAL "hifi5")
set(NNLIB_DIR_NAME "nnlib-hifi5")
else()
set(NNLIB_DIR_NAME "nnlib-hifi4")
endif()

add_custom_target(
nnlib_target ALL
COMMAND
make install_nnlib -f makefile -C
${EXECUTORCH_ROOT}/backends/cadence/hifi/third-party/nnlib/nnlib-hifi4/xa_nnlib/build
${EXECUTORCH_ROOT}/backends/cadence/hifi/third-party/nnlib/${NNLIB_DIR_NAME}/xa_nnlib/build
OBJDIR=${CMAKE_CURRENT_BINARY_DIR}/obj
LIBDIR=${CMAKE_CURRENT_BINARY_DIR}/lib -j8
)
Expand Down
6 changes: 5 additions & 1 deletion backends/cadence/hifi/third-party/nnlib/xa_nn_reduce_32_32.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
#include "xa_nnlib_common.h"
#include <string.h>
//#include "xa_nn_basic_state.h"
#include "xa_nnlib_common_macros.h"
#if CORE_HIFI5
#include <xa_nnlib_common_macros_hifi5.h>
#else
#include <xa_nnlib_common_macros.h>
#endif

#define ALIGNMENT_8 8

Expand Down
26 changes: 18 additions & 8 deletions backends/cadence/install_requirements.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,28 +10,38 @@ green=`tput setaf 2`

EXECUTORCH_ROOT_PATH=$(realpath "$SCRIPT_DIR_PATH/../../")
CADENCE_DIR_PATH="$EXECUTORCH_ROOT_PATH/backends/cadence"
HIFI_DIR_PATH="$CADENCE_DIR_PATH/hifi/third-party/nnlib/nnlib-hifi4"
HIFI4_DIR_PATH="$CADENCE_DIR_PATH/hifi/third-party/nnlib/nnlib-hifi4"
HIFI5_DIR_PATH="$CADENCE_DIR_PATH/hifi/third-party/nnlib/nnlib-hifi5"
FUSION_DIR_PATH="$CADENCE_DIR_PATH/fusion_g3/third-party/nnlib/nnlib-FusionG3"
FACTO_DIR_PATH="$CADENCE_DIR_PATH/utils/FACTO"

cd "$EXECUTORCH_ROOT_PATH"

## HiFi

rm -rf "$HIFI_DIR_PATH"
mkdir -p "$HIFI_DIR_PATH"
rm -rf "$HIFI4_DIR_PATH"
mkdir -p "$HIFI4_DIR_PATH"

echo "${green}ExecuTorch: Cloning hifi nnlib"
git clone "https://github.com/foss-xtensa/nnlib-hifi4.git" $HIFI_DIR_PATH
cd $HIFI_DIR_PATH
echo "${green}ExecuTorch: Cloning hifi4 nnlib"
git clone "https://github.com/foss-xtensa/nnlib-hifi4.git" $HIFI4_DIR_PATH
cd $HIFI4_DIR_PATH
STATUS=$?
if [ $STATUS -ne 0 ]; then
echo "${red}ExecuTorch: Failed to clone hifi nnlib."
echo "${red}ExecuTorch: Failed to clone hifi4 nnlib."
exit 1
fi

git checkout 64d73d729797388b0e346794d7a2e408374a74de
rm -rf "$HIFI5_DIR_PATH"
mkdir -p "$HIFI5_DIR_PATH"

echo "${green}ExecuTorch: Cloning hifi5 nnlib"
git clone "https://github.com/foss-xtensa/nnlib-hifi5.git" $HIFI5_DIR_PATH
cd $HIFI5_DIR_PATH
STATUS=$?
if [ $STATUS -ne 0 ]; then
echo "${red}ExecuTorch: Failed to clone hifi5 nnlib."
exit 1
fi
Comment thread
dijopaul marked this conversation as resolved.
Outdated

## Fusion G3

Expand Down
Loading