Skip to content

[Test] Use class references instead of lambdas in transform tests #3279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vmoens merged 2 commits into from
Dec 31, 2025
Merged

[Test] Use class references instead of lambdas in transform tests #3279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca69b11
Update
vmoens Dec 31, 2025
3d44a2d
Update
vmoens Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions test/test_transforms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ def test_trans_serial_env_check(self):

def test_trans_parallel_env_check(self, maybe_fork_ParallelEnv):
env = TransformedEnv(
maybe_fork_ParallelEnv(2, lambda: ContinuousActionVecMockEnv()),
maybe_fork_ParallelEnv(2, ContinuousActionVecMockEnv),
BinarizeReward(),
)
try:
Expand Down Expand Up @@ -842,7 +842,7 @@ def test_trans_serial_env_check(self):

def test_trans_parallel_env_check(self, maybe_fork_ParallelEnv):
env = TransformedEnv(
maybe_fork_ParallelEnv(2, lambda: ContinuousActionVecMockEnv()),
maybe_fork_ParallelEnv(2, ContinuousActionVecMockEnv),
CatFrames(dim=-1, N=3, in_keys=["observation"]),
)
try:
Expand Down Expand Up @@ -1481,7 +1481,7 @@ def test_trans_parallel_env_check(self, model, device):
tensor_pixels_keys=tensor_pixels_key,
)
transformed_env = TransformedEnv(
ParallelEnv(2, lambda: DiscreteActionConvMockEnvNumpy().to(device)), r3m
ParallelEnv(2, partial(DiscreteActionConvMockEnvNumpy, device=device)), r3m
)
try:
check_env_specs(transformed_env)
Expand Down Expand Up @@ -1639,7 +1639,9 @@ def test_r3m_parallel(self, model, device):
out_keys=out_keys,
tensor_pixels_keys=tensor_pixels_key,
)
base_env = ParallelEnv(4, lambda: DiscreteActionConvMockEnvNumpy().to(device))
base_env = ParallelEnv(
4, partial(DiscreteActionConvMockEnvNumpy, device=device)
)
transformed_env = TransformedEnv(base_env, r3m)
td = transformed_env.reset()
assert td.device == device
Expand Down Expand Up @@ -8503,7 +8505,7 @@ def test_trans_serial_env_check(self):

def test_trans_parallel_env_check(self, maybe_fork_ParallelEnv):
env = TransformedEnv(
maybe_fork_ParallelEnv(2, lambda: ContinuousActionVecMockEnv()),
maybe_fork_ParallelEnv(2, ContinuousActionVecMockEnv),
TimeMaxPool(
in_keys=["observation"],
T=3,
Expand Down Expand Up @@ -8830,7 +8832,7 @@ def test_trans_parallel_env_check(self, model, device):
tensor_pixels_keys=tensor_pixels_key,
)
transformed_env = TransformedEnv(
ParallelEnv(2, lambda: DiscreteActionConvMockEnvNumpy().to(device)), vip
ParallelEnv(2, partial(DiscreteActionConvMockEnvNumpy, device=device)), vip
)
try:
check_env_specs(transformed_env)
Expand Down Expand Up @@ -9056,7 +9058,9 @@ def test_transform_env(self, model, device):
out_keys=out_keys,
tensor_pixels_keys=tensor_pixels_key,
)
base_env = ParallelEnv(4, lambda: DiscreteActionConvMockEnvNumpy().to(device))
base_env = ParallelEnv(
4, partial(DiscreteActionConvMockEnvNumpy, device=device)
)
transformed_env = TransformedEnv(base_env, vip)
td = transformed_env.reset()
assert td.device == device
Expand Down Expand Up @@ -9093,7 +9097,9 @@ def test_vip_parallel_reward(self, model, device, dtype_fixture): # noqa
out_keys=out_keys,
tensor_pixels_keys=tensor_pixels_key,
)
base_env = ParallelEnv(4, lambda: DiscreteActionConvMockEnvNumpy().to(device))
base_env = ParallelEnv(
4, partial(DiscreteActionConvMockEnvNumpy, device=device)
)
transformed_env = TransformedEnv(base_env, vip)
tensordict_reset = TensorDict(
{"goal_image": torch.randint(0, 255, (4, 7, 7, 3), dtype=torch.uint8)},
Expand Down Expand Up @@ -9296,7 +9302,7 @@ def test_trans_parallel_env_check(self, device):
model_name="default",
)
transformed_env = TransformedEnv(
ParallelEnv(2, lambda: DiscreteActionConvMockEnvNumpy().to(device)), vc1
ParallelEnv(2, partial(DiscreteActionConvMockEnvNumpy, device=device)), vc1
)
try:
check_env_specs(transformed_env)
Expand Down Expand Up @@ -9452,7 +9458,9 @@ def test_transform_env(self, device, del_keys):
del_keys=del_keys,
model_name="default",
)
base_env = ParallelEnv(4, lambda: DiscreteActionConvMockEnvNumpy().to(device))
base_env = ParallelEnv(
4, partial(DiscreteActionConvMockEnvNumpy, device=device)
)
transformed_env = TransformedEnv(base_env, vc1)
td = transformed_env.reset()
assert td.device == device
Expand Down Expand Up @@ -14763,7 +14771,7 @@ def test_trans_serial_env_check(self):

def test_trans_parallel_env_check(self, maybe_fork_ParallelEnv):
env = TransformedEnv(
maybe_fork_ParallelEnv(2, lambda: ContinuousActionVecMockEnv()),
maybe_fork_ParallelEnv(2, ContinuousActionVecMockEnv),
Timer(),
)
try:
Expand Down
1 change: 0 additions & 1 deletion torchrl/envs/batched_envs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1450,7 +1450,6 @@ class ParallelEnv(BatchedEnvBase, metaclass=_PEnvMeta):

def _start_workers(self) -> None:
import torchrl
from torchrl.envs.env_creator import EnvCreator

self._timeout = 10.0
self.BATCHED_PIPE_TIMEOUT = torchrl._utils.BATCHED_PIPE_TIMEOUT
Expand Down
Loading