Skip to content

[Test] Use class references instead of lambdas in transform tests #3279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vmoens merged 2 commits into from
Dec 31, 2025
Merged

[Test] Use class references instead of lambdas in transform tests #3279

vmoens merged 2 commits into from
Dec 31, 2025

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Dec 31, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@vmoens
Update
ca69b11 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 31, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3279

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vmoens added a commit that referenced this pull request Dec 31, 2025
@vmoens
[Test] Use class references instead of lambdas in transform tests
0e77ae0 
ghstack-source-id: a13f3f2
Pull-Request: #3279
This was referenced Dec 31, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 31, 2025
@vmoens
Update
3d44a2d 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Dec 31, 2025
@vmoens
[Test] Use class references instead of lambdas in transform tests
f2784d5 
ghstack-source-id: 9734eac
Pull-Request: #3279
vmoens added a commit that referenced this pull request Dec 31, 2025
@vmoens
[Test] Use class references instead of lambdas in transform tests
7dd1e61 
ghstack-source-id: 9734eac
Pull-Request: #3279
@vmoens vmoens merged commit 3d44a2d into gh/vmoens/179/base Dec 31, 2025
74 of 94 checks passed
@vmoens vmoens deleted the gh/vmoens/179/head branch December 31, 2025 09:17
@github-actions
Copy link

github-actions bot commented Dec 31, 2025

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 164. Improved: $\large\color{#35bf28}31$. Worsened: $\large\color{#d91a1a}12$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_tensor_to_bytestream_speed[pickle] 79.8664μs 78.4506μs 12.7469 KOps/s 11.9969 KOps/s $\textbf{\color{#35bf28}+6.25\%}$
test_tensor_to_bytestream_speed[torch.save] 0.1393ms 0.1380ms 7.2461 KOps/s 7.2038 KOps/s $\color{#35bf28}+0.59\%$
test_tensor_to_bytestream_speed[untyped_storage] 0.1129s 0.1122s 8.9152 Ops/s 8.4798 Ops/s $\textbf{\color{#35bf28}+5.13\%}$
test_tensor_to_bytestream_speed[numpy] 2.5885μs 2.5809μs 387.4632 KOps/s 372.8139 KOps/s $\color{#35bf28}+3.93\%$
test_tensor_to_bytestream_speed[safetensors] 36.4915μs 36.2199μs 27.6091 KOps/s 24.7713 KOps/s $\textbf{\color{#35bf28}+11.46\%}$
test_simple 0.5411s 0.5377s 1.8599 Ops/s 1.7807 Ops/s $\color{#35bf28}+4.45\%$
test_transformed 1.1149s 1.1085s 0.9021 Ops/s 0.8837 Ops/s $\color{#35bf28}+2.08\%$
test_serial 1.6267s 1.6204s 0.6171 Ops/s 0.5981 Ops/s $\color{#35bf28}+3.18\%$
test_parallel 1.2299s 1.1692s 0.8553 Ops/s 0.8443 Ops/s $\color{#35bf28}+1.30\%$
test_step_mdp_speed[True-True-True-True-True] 0.3179ms 44.0315μs 22.7110 KOps/s 22.3258 KOps/s $\color{#35bf28}+1.73\%$
test_step_mdp_speed[True-True-True-True-False] 87.9720μs 24.1429μs 41.4201 KOps/s 40.8159 KOps/s $\color{#35bf28}+1.48\%$
test_step_mdp_speed[True-True-True-False-True] 53.3210μs 24.3758μs 41.0243 KOps/s 40.9479 KOps/s $\color{#35bf28}+0.19\%$
test_step_mdp_speed[True-True-True-False-False] 37.7500μs 13.7521μs 72.7159 KOps/s 74.4193 KOps/s $\color{#d91a1a}-2.29\%$
test_step_mdp_speed[True-True-False-True-True] 81.8110μs 46.0146μs 21.7322 KOps/s 21.6151 KOps/s $\color{#35bf28}+0.54\%$
test_step_mdp_speed[True-True-False-True-False] 53.6010μs 26.9826μs 37.0609 KOps/s 37.1996 KOps/s $\color{#d91a1a}-0.37\%$
test_step_mdp_speed[True-True-False-False-True] 52.2710μs 26.6209μs 37.5645 KOps/s 36.5208 KOps/s $\color{#35bf28}+2.86\%$
test_step_mdp_speed[True-True-False-False-False] 41.3110μs 15.9717μs 62.6108 KOps/s 62.0552 KOps/s $\color{#35bf28}+0.90\%$
test_step_mdp_speed[True-False-True-True-True] 78.8410μs 48.6732μs 20.5452 KOps/s 19.9899 KOps/s $\color{#35bf28}+2.78\%$
test_step_mdp_speed[True-False-True-True-False] 61.5810μs 29.1419μs 34.3149 KOps/s 34.0783 KOps/s $\color{#35bf28}+0.69\%$
test_step_mdp_speed[True-False-True-False-True] 56.6210μs 27.1234μs 36.8686 KOps/s 36.5459 KOps/s $\color{#35bf28}+0.88\%$
test_step_mdp_speed[True-False-True-False-False] 45.0300μs 16.0299μs 62.3833 KOps/s 61.8421 KOps/s $\color{#35bf28}+0.88\%$
test_step_mdp_speed[True-False-False-True-True] 80.4910μs 50.4669μs 19.8150 KOps/s 19.0480 KOps/s $\color{#35bf28}+4.03\%$
test_step_mdp_speed[True-False-False-True-False] 57.6110μs 31.6329μs 31.6127 KOps/s 30.9003 KOps/s $\color{#35bf28}+2.31\%$
test_step_mdp_speed[True-False-False-False-True] 60.3210μs 28.8932μs 34.6102 KOps/s 33.3468 KOps/s $\color{#35bf28}+3.79\%$
test_step_mdp_speed[True-False-False-False-False] 44.2910μs 18.5240μs 53.9840 KOps/s 53.4921 KOps/s $\color{#35bf28}+0.92\%$
test_step_mdp_speed[False-True-True-True-True] 94.1310μs 48.3677μs 20.6750 KOps/s 20.0902 KOps/s $\color{#35bf28}+2.91\%$
test_step_mdp_speed[False-True-True-True-False] 59.5910μs 29.7602μs 33.6020 KOps/s 33.5769 KOps/s $\color{#35bf28}+0.07\%$
test_step_mdp_speed[False-True-True-False-True] 2.4208ms 30.1360μs 33.1829 KOps/s 32.4451 KOps/s $\color{#35bf28}+2.27\%$
test_step_mdp_speed[False-True-True-False-False] 50.5810μs 17.5541μs 56.9668 KOps/s 55.6441 KOps/s $\color{#35bf28}+2.38\%$
test_step_mdp_speed[False-True-False-True-True] 81.4420μs 50.4355μs 19.8273 KOps/s 19.0695 KOps/s $\color{#35bf28}+3.97\%$
test_step_mdp_speed[False-True-False-True-False] 57.0710μs 31.9817μs 31.2678 KOps/s 31.5914 KOps/s $\color{#d91a1a}-1.02\%$
test_step_mdp_speed[False-True-False-False-True] 61.1210μs 32.3602μs 30.9022 KOps/s 30.4460 KOps/s $\color{#35bf28}+1.50\%$
test_step_mdp_speed[False-True-False-False-False] 50.0710μs 20.0593μs 49.8521 KOps/s 49.7453 KOps/s $\color{#35bf28}+0.21\%$
test_step_mdp_speed[False-False-True-True-True] 84.6520μs 54.4223μs 18.3748 KOps/s 18.0893 KOps/s $\color{#35bf28}+1.58\%$
test_step_mdp_speed[False-False-True-True-False] 73.2010μs 35.1126μs 28.4798 KOps/s 28.2716 KOps/s $\color{#35bf28}+0.74\%$
test_step_mdp_speed[False-False-True-False-True] 66.5120μs 32.9473μs 30.3515 KOps/s 29.8009 KOps/s $\color{#35bf28}+1.85\%$
test_step_mdp_speed[False-False-True-False-False] 48.1610μs 19.8835μs 50.2929 KOps/s 49.6524 KOps/s $\color{#35bf28}+1.29\%$
test_step_mdp_speed[False-False-False-True-True] 88.2520μs 56.0089μs 17.8543 KOps/s 17.6102 KOps/s $\color{#35bf28}+1.39\%$
test_step_mdp_speed[False-False-False-True-False] 68.0110μs 37.1683μs 26.9047 KOps/s 26.3322 KOps/s $\color{#35bf28}+2.17\%$
test_step_mdp_speed[False-False-False-False-True] 71.2310μs 35.0789μs 28.5072 KOps/s 27.6088 KOps/s $\color{#35bf28}+3.25\%$
test_step_mdp_speed[False-False-False-False-False] 55.0110μs 22.5842μs 44.2788 KOps/s 43.8227 KOps/s $\color{#35bf28}+1.04\%$
test_non_tensor_env_rollout_speed[1000-single-True] 0.8574s 0.7590s 1.3175 Ops/s 1.3155 Ops/s $\color{#35bf28}+0.15\%$
test_non_tensor_env_rollout_speed[1000-single-False] 0.7272s 0.6286s 1.5908 Ops/s 1.5895 Ops/s $\color{#35bf28}+0.08\%$
test_non_tensor_env_rollout_speed[1000-serial-no-buffers-True] 1.7360s 1.6590s 0.6028 Ops/s 0.6021 Ops/s $\color{#35bf28}+0.12\%$
test_non_tensor_env_rollout_speed[1000-serial-no-buffers-False] 1.5235s 1.4454s 0.6919 Ops/s 0.6927 Ops/s $\color{#d91a1a}-0.13\%$
test_non_tensor_env_rollout_speed[1000-serial-buffers-True] 1.9778s 1.8969s 0.5272 Ops/s 0.5238 Ops/s $\color{#35bf28}+0.65\%$
test_non_tensor_env_rollout_speed[1000-serial-buffers-False] 1.7595s 1.6808s 0.5949 Ops/s 0.5923 Ops/s $\color{#35bf28}+0.45\%$
test_non_tensor_env_rollout_speed[1000-parallel-no-buffers-True] 4.7822s 4.6623s 0.2145 Ops/s 0.2197 Ops/s $\color{#d91a1a}-2.38\%$
test_non_tensor_env_rollout_speed[1000-parallel-no-buffers-False] 4.5899s 4.4372s 0.2254 Ops/s 0.2201 Ops/s $\color{#35bf28}+2.38\%$
test_non_tensor_env_rollout_speed[1000-parallel-buffers-True] 2.0439s 1.9647s 0.5090 Ops/s 0.5204 Ops/s $\color{#d91a1a}-2.19\%$
test_non_tensor_env_rollout_speed[1000-parallel-buffers-False] 1.7809s 1.6734s 0.5976 Ops/s 0.6110 Ops/s $\color{#d91a1a}-2.19\%$
test_values[generalized_advantage_estimate-True-True] 10.1160ms 9.9411ms 100.5925 Ops/s 93.6931 Ops/s $\textbf{\color{#35bf28}+7.36\%}$
test_values[vec_generalized_advantage_estimate-True-True] 19.4360ms 17.7302ms 56.4009 Ops/s 88.3572 Ops/s $\textbf{\color{#d91a1a}-36.17\%}$
test_values[td0_return_estimate-False-False] 0.2402ms 0.1320ms 7.5784 KOps/s 7.9114 KOps/s $\color{#d91a1a}-4.21\%$
test_values[td1_return_estimate-False-False] 27.6268ms 26.9883ms 37.0530 Ops/s 34.8910 Ops/s $\textbf{\color{#35bf28}+6.20\%}$
test_values[vec_td1_return_estimate-False-False] 19.0640ms 17.8566ms 56.0016 Ops/s 88.7913 Ops/s $\textbf{\color{#d91a1a}-36.93\%}$
test_values[td_lambda_return_estimate-True-False] 41.0380ms 39.6494ms 25.2211 Ops/s 23.7076 Ops/s $\textbf{\color{#35bf28}+6.38\%}$
test_values[vec_td_lambda_return_estimate-True-False] 18.1094ms 17.7728ms 56.2658 Ops/s 88.0785 Ops/s $\textbf{\color{#d91a1a}-36.12\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 9.0320ms 8.8507ms 112.9850 Ops/s 106.0119 Ops/s $\textbf{\color{#35bf28}+6.58\%}$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.7521ms 1.5369ms 650.6731 Ops/s 633.5821 Ops/s $\color{#35bf28}+2.70\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4664ms 0.4133ms 2.4194 KOps/s 2.3149 KOps/s $\color{#35bf28}+4.52\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 35.3016ms 31.7679ms 31.4783 Ops/s 37.6075 Ops/s $\textbf{\color{#d91a1a}-16.30\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 1.9562ms 1.8071ms 553.3638 Ops/s 550.9592 Ops/s $\color{#35bf28}+0.44\%$
test_dqn_speed[False-None] 1.5834ms 1.3683ms 730.8434 Ops/s 720.9864 Ops/s $\color{#35bf28}+1.37\%$
test_dqn_speed[False-backward] 1.9629ms 1.8824ms 531.2234 Ops/s 533.5794 Ops/s $\color{#d91a1a}-0.44\%$
test_dqn_speed[True-None] 0.5919ms 0.5159ms 1.9383 KOps/s 1.9049 KOps/s $\color{#35bf28}+1.76\%$
test_dqn_speed[True-backward] 1.0012ms 0.9624ms 1.0390 KOps/s 920.5454 Ops/s $\textbf{\color{#35bf28}+12.87\%}$
test_dqn_speed[reduce-overhead-None] 0.6047ms 0.5144ms 1.9441 KOps/s 1.7849 KOps/s $\textbf{\color{#35bf28}+8.91\%}$
test_dqn_speed[reduce-overhead-backward] 1.0394ms 0.9454ms 1.0577 KOps/s 1.0291 KOps/s $\color{#35bf28}+2.78\%$
test_ddpg_speed[False-None] 3.0705ms 2.7989ms 357.2834 Ops/s 354.2122 Ops/s $\color{#35bf28}+0.87\%$
test_ddpg_speed[False-backward] 4.3451ms 4.0038ms 249.7652 Ops/s 244.7739 Ops/s $\color{#35bf28}+2.04\%$
test_ddpg_speed[True-None] 1.4271ms 1.3531ms 739.0561 Ops/s 725.4840 Ops/s $\color{#35bf28}+1.87\%$
test_ddpg_speed[True-backward] 2.3973ms 2.3274ms 429.6694 Ops/s 411.2962 Ops/s $\color{#35bf28}+4.47\%$
test_ddpg_speed[reduce-overhead-None] 1.4476ms 1.3546ms 738.2434 Ops/s 716.1015 Ops/s $\color{#35bf28}+3.09\%$
test_ddpg_speed[reduce-overhead-backward] 2.3793ms 2.3171ms 431.5744 Ops/s 368.8374 Ops/s $\textbf{\color{#35bf28}+17.01\%}$
test_sac_speed[False-None] 8.4825ms 7.8725ms 127.0251 Ops/s 126.4070 Ops/s $\color{#35bf28}+0.49\%$
test_sac_speed[False-backward] 11.5062ms 10.9881ms 91.0079 Ops/s 89.6223 Ops/s $\color{#35bf28}+1.55\%$
test_sac_speed[True-None] 2.2382ms 2.0949ms 477.3522 Ops/s 455.9768 Ops/s $\color{#35bf28}+4.69\%$
test_sac_speed[True-backward] 4.1718ms 3.9770ms 251.4430 Ops/s 235.8301 Ops/s $\textbf{\color{#35bf28}+6.62\%}$
test_sac_speed[reduce-overhead-None] 2.2330ms 2.0802ms 480.7184 Ops/s 471.3481 Ops/s $\color{#35bf28}+1.99\%$
test_sac_speed[reduce-overhead-backward] 4.1927ms 4.0119ms 249.2577 Ops/s 237.1335 Ops/s $\textbf{\color{#35bf28}+5.11\%}$
test_redq_speed[False-None] 14.9608ms 10.2540ms 97.5225 Ops/s 98.0912 Ops/s $\color{#d91a1a}-0.58\%$
test_redq_speed[False-backward] 19.1042ms 17.6035ms 56.8070 Ops/s 57.7233 Ops/s $\color{#d91a1a}-1.59\%$
test_redq_speed[True-None] 4.6693ms 4.3288ms 231.0101 Ops/s 224.2275 Ops/s $\color{#35bf28}+3.02\%$
test_redq_speed[True-backward] 9.9982ms 9.7121ms 102.9639 Ops/s 97.8899 Ops/s $\textbf{\color{#35bf28}+5.18\%}$
test_redq_speed[reduce-overhead-None] 4.5210ms 4.2773ms 233.7916 Ops/s 228.1619 Ops/s $\color{#35bf28}+2.47\%$
test_redq_speed[reduce-overhead-backward] 10.2093ms 9.7457ms 102.6092 Ops/s 98.8062 Ops/s $\color{#35bf28}+3.85\%$
test_redq_deprec_speed[False-None] 11.1799ms 10.8086ms 92.5186 Ops/s 88.7130 Ops/s $\color{#35bf28}+4.29\%$
test_redq_deprec_speed[False-backward] 16.0276ms 15.6016ms 64.0958 Ops/s 60.9353 Ops/s $\textbf{\color{#35bf28}+5.19\%}$
test_redq_deprec_speed[True-None] 3.7706ms 3.5972ms 277.9944 Ops/s 260.8045 Ops/s $\textbf{\color{#35bf28}+6.59\%}$
test_redq_deprec_speed[True-backward] 7.7066ms 7.4777ms 133.7307 Ops/s 136.1295 Ops/s $\color{#d91a1a}-1.76\%$
test_redq_deprec_speed[reduce-overhead-None] 3.7376ms 3.5011ms 285.6240 Ops/s 274.7694 Ops/s $\color{#35bf28}+3.95\%$
test_redq_deprec_speed[reduce-overhead-backward] 7.7084ms 7.4509ms 134.2116 Ops/s 134.8356 Ops/s $\color{#d91a1a}-0.46\%$
test_td3_speed[False-None] 8.0698ms 7.8695ms 127.0727 Ops/s 125.7742 Ops/s $\color{#35bf28}+1.03\%$
test_td3_speed[False-backward] 11.1894ms 10.7530ms 92.9975 Ops/s 92.9002 Ops/s $\color{#35bf28}+0.10\%$
test_td3_speed[True-None] 1.8009ms 1.7715ms 564.4850 Ops/s 554.9036 Ops/s $\color{#35bf28}+1.73\%$
test_td3_speed[True-backward] 3.6822ms 3.5657ms 280.4532 Ops/s 251.6940 Ops/s $\textbf{\color{#35bf28}+11.43\%}$
test_td3_speed[reduce-overhead-None] 1.8494ms 1.7694ms 565.1617 Ops/s 564.2551 Ops/s $\color{#35bf28}+0.16\%$
test_td3_speed[reduce-overhead-backward] 3.7759ms 3.6283ms 275.6098 Ops/s 256.4220 Ops/s $\textbf{\color{#35bf28}+7.48\%}$
test_cql_speed[False-None] 30.0356ms 26.2422ms 38.1066 Ops/s 38.7743 Ops/s $\color{#d91a1a}-1.72\%$
test_cql_speed[False-backward] 35.3421ms 34.6233ms 28.8823 Ops/s 28.5795 Ops/s $\color{#35bf28}+1.06\%$
test_cql_speed[True-None] 12.6660ms 12.1875ms 82.0510 Ops/s 85.5157 Ops/s $\color{#d91a1a}-4.05\%$
test_cql_speed[True-backward] 17.8382ms 17.4577ms 57.2814 Ops/s 56.2807 Ops/s $\color{#35bf28}+1.78\%$
test_cql_speed[reduce-overhead-None] 12.4620ms 12.1087ms 82.5849 Ops/s 81.1093 Ops/s $\color{#35bf28}+1.82\%$
test_cql_speed[reduce-overhead-backward] 18.1815ms 17.5494ms 56.9821 Ops/s 57.4368 Ops/s $\color{#d91a1a}-0.79\%$
test_a2c_speed[False-None] 5.8157ms 5.2940ms 188.8941 Ops/s 183.1616 Ops/s $\color{#35bf28}+3.13\%$
test_a2c_speed[False-backward] 12.0001ms 11.6899ms 85.5442 Ops/s 85.0099 Ops/s $\color{#35bf28}+0.63\%$
test_a2c_speed[True-None] 3.7569ms 3.6143ms 276.6771 Ops/s 269.5982 Ops/s $\color{#35bf28}+2.63\%$
test_a2c_speed[True-backward] 8.9195ms 8.4691ms 118.0765 Ops/s 118.6357 Ops/s $\color{#d91a1a}-0.47\%$
test_a2c_speed[reduce-overhead-None] 3.8840ms 3.6569ms 273.4588 Ops/s 274.2540 Ops/s $\color{#d91a1a}-0.29\%$
test_a2c_speed[reduce-overhead-backward] 8.8124ms 8.6167ms 116.0537 Ops/s 111.3562 Ops/s $\color{#35bf28}+4.22\%$
test_ppo_speed[False-None] 6.0351ms 5.6793ms 176.0795 Ops/s 176.3173 Ops/s $\color{#d91a1a}-0.13\%$
test_ppo_speed[False-backward] 12.7520ms 12.2413ms 81.6907 Ops/s 81.4389 Ops/s $\color{#35bf28}+0.31\%$
test_ppo_speed[True-None] 3.6944ms 3.5526ms 281.4833 Ops/s 277.9051 Ops/s $\color{#35bf28}+1.29\%$
test_ppo_speed[True-backward] 8.6682ms 8.3622ms 119.5855 Ops/s 120.3781 Ops/s $\color{#d91a1a}-0.66\%$
test_ppo_speed[reduce-overhead-None] 4.0421ms 3.5056ms 285.2580 Ops/s 279.8795 Ops/s $\color{#35bf28}+1.92\%$
test_ppo_speed[reduce-overhead-backward] 8.7831ms 8.5609ms 116.8101 Ops/s 110.2571 Ops/s $\textbf{\color{#35bf28}+5.94\%}$
test_reinforce_speed[False-None] 5.2389ms 4.5008ms 222.1822 Ops/s 225.8647 Ops/s $\color{#d91a1a}-1.63\%$
test_reinforce_speed[False-backward] 7.5348ms 7.3020ms 136.9486 Ops/s 137.0880 Ops/s $\color{#d91a1a}-0.10\%$
test_reinforce_speed[True-None] 2.9800ms 2.7939ms 357.9197 Ops/s 351.5056 Ops/s $\color{#35bf28}+1.82\%$
test_reinforce_speed[True-backward] 7.8101ms 7.5621ms 132.2382 Ops/s 130.2351 Ops/s $\color{#35bf28}+1.54\%$
test_reinforce_speed[reduce-overhead-None] 2.9979ms 2.7842ms 359.1695 Ops/s 356.0222 Ops/s $\color{#35bf28}+0.88\%$
test_reinforce_speed[reduce-overhead-backward] 8.0436ms 7.8264ms 127.7728 Ops/s 117.7828 Ops/s $\textbf{\color{#35bf28}+8.48\%}$
test_iql_speed[False-None] 24.9350ms 19.8691ms 50.3294 Ops/s 50.6088 Ops/s $\color{#d91a1a}-0.55\%$
test_iql_speed[False-backward] 35.7119ms 30.2983ms 33.0051 Ops/s 32.8805 Ops/s $\color{#35bf28}+0.38\%$
test_iql_speed[True-None] 8.7545ms 8.3774ms 119.3681 Ops/s 116.7992 Ops/s $\color{#35bf28}+2.20\%$
test_iql_speed[True-backward] 17.2326ms 16.4226ms 60.8915 Ops/s 60.8571 Ops/s $\color{#35bf28}+0.06\%$
test_iql_speed[reduce-overhead-None] 8.7205ms 8.4415ms 118.4617 Ops/s 115.1685 Ops/s $\color{#35bf28}+2.86\%$
test_iql_speed[reduce-overhead-backward] 17.2343ms 16.8632ms 59.3008 Ops/s 58.8018 Ops/s $\color{#35bf28}+0.85\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.9198ms 5.9290ms 168.6613 Ops/s 165.8177 Ops/s $\color{#35bf28}+1.71\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6075ms 0.3065ms 3.2631 KOps/s 2.6855 KOps/s $\textbf{\color{#35bf28}+21.51\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6717ms 0.3882ms 2.5762 KOps/s 2.7890 KOps/s $\textbf{\color{#d91a1a}-7.63\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.0116ms 5.6774ms 176.1363 Ops/s 173.1661 Ops/s $\color{#35bf28}+1.72\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.9483ms 0.3438ms 2.9088 KOps/s 2.7481 KOps/s $\textbf{\color{#35bf28}+5.85\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6096ms 0.2953ms 3.3864 KOps/s 2.8696 KOps/s $\textbf{\color{#35bf28}+18.01\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.6740ms 1.3598ms 735.4122 Ops/s 689.6517 Ops/s $\textbf{\color{#35bf28}+6.64\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.5490ms 1.2758ms 783.8345 Ops/s 728.1128 Ops/s $\textbf{\color{#35bf28}+7.65\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 9.6230ms 5.9251ms 168.7747 Ops/s 167.6382 Ops/s $\color{#35bf28}+0.68\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.9015ms 0.4735ms 2.1120 KOps/s 2.1011 KOps/s $\color{#35bf28}+0.52\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8514ms 0.4023ms 2.4856 KOps/s 2.1979 KOps/s $\textbf{\color{#35bf28}+13.09\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.7205ms 5.6102ms 178.2454 Ops/s 172.6535 Ops/s $\color{#35bf28}+3.24\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7782ms 0.3407ms 2.9354 KOps/s 3.5569 KOps/s $\textbf{\color{#d91a1a}-17.47\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5740ms 0.3443ms 2.9044 KOps/s 3.8235 KOps/s $\textbf{\color{#d91a1a}-24.04\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.9282ms 5.6906ms 175.7293 Ops/s 174.0497 Ops/s $\color{#35bf28}+0.96\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7154ms 0.3111ms 3.2142 KOps/s 2.7850 KOps/s $\textbf{\color{#35bf28}+15.41\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.4880ms 0.2711ms 3.6880 KOps/s 3.2180 KOps/s $\textbf{\color{#35bf28}+14.61\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.0054ms 5.8205ms 171.8074 Ops/s 169.0975 Ops/s $\color{#35bf28}+1.60\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.2414ms 0.5246ms 1.9062 KOps/s 2.0961 KOps/s $\textbf{\color{#d91a1a}-9.06\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9680ms 0.4990ms 2.0039 KOps/s 2.1754 KOps/s $\textbf{\color{#d91a1a}-7.88\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 6.2878ms 4.9218ms 203.1766 Ops/s 51.4117 Ops/s $\textbf{\color{#35bf28}+295.20\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 7.8230ms 2.3808ms 420.0279 Ops/s 508.1053 Ops/s $\textbf{\color{#d91a1a}-17.33\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 7.9662ms 1.1872ms 842.3471 Ops/s 801.5962 Ops/s $\textbf{\color{#35bf28}+5.08\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 7.0675ms 4.9942ms 200.2323 Ops/s 197.6317 Ops/s $\color{#35bf28}+1.32\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 8.3868ms 2.2903ms 436.6305 Ops/s 471.0297 Ops/s $\textbf{\color{#d91a1a}-7.30\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 7.2878ms 1.2185ms 820.6633 Ops/s 800.6687 Ops/s $\color{#35bf28}+2.50\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.6231s 17.5769ms 56.8927 Ops/s 191.6691 Ops/s $\textbf{\color{#d91a1a}-70.32\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 11.8891ms 2.0817ms 480.3844 Ops/s 448.6149 Ops/s $\textbf{\color{#35bf28}+7.08\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.2761ms 1.0083ms 991.7758 Ops/s 769.1863 Ops/s $\textbf{\color{#35bf28}+28.94\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 36.4531ms 33.2723ms 30.0551 Ops/s 28.7531 Ops/s $\color{#35bf28}+4.53\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 18.9682ms 17.4886ms 57.1802 Ops/s 56.6905 Ops/s $\color{#35bf28}+0.86\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 36.0614ms 33.9745ms 29.4339 Ops/s 28.4297 Ops/s $\color{#35bf28}+3.53\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 19.2274ms 17.6487ms 56.6613 Ops/s 55.6975 Ops/s $\color{#35bf28}+1.73\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 39.0064ms 35.7131ms 28.0009 Ops/s 27.0388 Ops/s $\color{#35bf28}+3.56\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 20.5808ms 19.2848ms 51.8542 Ops/s 52.2792 Ops/s $\color{#d91a1a}-0.81\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vmoens