-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows AMI Pin vs 2022 to older msvc release #5337
Conversation
@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to add a reference to VC++ version CUDA supports
Also, why it affects only vision but not the core? Should we perhaps update something there?
Very detailed info on this comment: pytorch/vision#8492 (comment) Good question why it does not affect core. Do we reinstall for core ? |
# Pin to older vs_buildtools version for cuda 11.8 and 12.1 builds | ||
# see issue: nerfstudio-project/nerfstudio#3157 | ||
if ( ${env:VS_YEAR} -eq "2022" ) { | ||
$VS_DOWNLOAD_LINK = "https://aka.ms/vs/17/release.ltsc.17.8/vs_buildtools.exe" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the casing of BuildTools.exe need to change between the two links? (line 8 and line 13)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 8 is still needed for MSVC 2019
Co-authored-by: Zain Rizvi <[email protected]>
See pytorch/vision#8492 for reference
Link taken from here: https://learn.microsoft.com/en-us/visualstudio/releases/2022/release-history#evergreen-bootstrappers