Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows AMI Pin vs 2022 to older msvc release #5337

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Windows AMI Pin vs 2022 to older msvc release #5337

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb34e1d
Pin vs 2022 to older msvc release
atalman Jun 13, 2024
a0b82ad
Update aws/ami/windows/scripts/Installers/Install-VS.ps1
atalman Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion aws/ami/windows/scripts/Installers/Install-VS.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,18 @@
# https://developercommunity.visualstudio.com/t/install-specific-version-of-vs-component/1142479
# Where to find the links:
# Where to find the links:
# - https://docs.microsoft.com/en-us/visualstudio/releases/2019/history#release-dates-and-build-numbers
# - https://learn.microsoft.com/en-us/visualstudio/releases/2022/release-history#fixed-version-bootstrappers
# BuildTools from S3
$VS_VERSION_major = [int] ${env:VS_VERSION}.split(".")[0]

$VS_DOWNLOAD_LINK = "https://aka.ms/vs/$VS_VERSION_major/release/vs_BuildTools.exe"

# Pin to older vs_buildtools version for cuda 11.8 and 12.1 builds
# see issue: https://github.com/nerfstudio-project/nerfstudio/issues/3157
if ( ${env:VS_YEAR} -eq "2022" ) {
$VS_DOWNLOAD_LINK = "https://aka.ms/vs/17/release.ltsc.17.8/vs_buildtools.exe"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the casing of BuildTools.exe need to change between the two links? (line 8 and line 13)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 8 is still needed for MSVC 2019

}

$COLLECT_DOWNLOAD_LINK = "https://aka.ms/vscollect.exe"
$VS_INSTALL_ARGS = @("--nocache","--quiet","--wait", "--add Microsoft.VisualStudio.Workload.VCTools",
"--add Microsoft.Component.MSBuild",
Expand Down
Loading