Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass allow-unsupported compiler flag for nvcc during compilation #8492

Closed
wants to merge 3 commits into from

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Jun 13, 2024

After updating to cudnn 9.1:
pytorch/test-infra#5295

Getting fatal error from NVCC:

C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v12.1\include\crt/host_config.h(153): fatal error C1189: #error:  -- unsupported Microsoft Visual Studio version! Only the versions between 2017 and 2022 (inclusive) are supported! The nvcc flag '-allow-unsupported-compiler' can be used to override this version check; however, using an unsupported host compiler may cause compilation failure or incorrect run time execution. Use at your own risk.
nms_kernel.cu

For cuda 12.1 and 11.8

Failure:
https://github.com/pytorch/vision/actions/runs/9502323845/job/26204631855

Primary Suspect small VC update:
Old:

** Visual Studio 2022 Developer Command Prompt v17.9.6

New :

** Visual Studio 2022 Developer Command Prompt v17.10.1

Copy link

pytorch-bot bot commented Jun 13, 2024

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

Copy link

pytorch-bot bot commented Jun 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8492

Note: Links to docs will display an error until the docs builds have been completed.

❌ 10 New Failures

As of commit d7f92dc with merge base 143d078 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ahmadsharif1 ahmadsharif1 self-assigned this Jun 13, 2024
@atalman atalman changed the title Test allow-unsupported compiler flag Pass allow-unsupported compiler flag for nvcc during compilation Jun 13, 2024
@nWEIdia
Copy link

nWEIdia commented Jun 13, 2024

nerfstudio-project/nerfstudio#3157 suggests:

CUDA Requirements:
MSVC Version 193x
Visual Studio 2022 17.x

17.10 is however 194x when checking the cl.exe file.

CUDA release pages were showing sth like:

image

image

and

image

So 17.10 (194x) would be too new for CUDA.

@atalman
Copy link
Contributor Author

atalman commented Jun 13, 2024

Closing this for now. AMI rolled back

@nWEIdia
Copy link

nWEIdia commented Jun 13, 2024

CUDA 11.8 Windows https://docs.nvidia.com/cuda/archive/11.8.0/cuda-installation-guide-microsoft-windows/index.html Table 2
CUDA 12.1 Windows https://docs.nvidia.com/cuda/archive/12.1.0/cuda-installation-guide-microsoft-windows/index.html Table 2
CUDA 12.4 Windows https://docs.nvidia.com/cuda/archive/12.4.0/cuda-installation-guide-microsoft-windows/index.html#id1

They did not seem to change, even though CUDA 12.4 has fixed the version check (and now supports MSVC 17.10.x) while dealing with MS's unconventional naming (bumping 19.3x to 19.4x to still map to 17.x, i.e. 17.10, instead of 18.x).

For future reference, if there is a need to bump to MSVC 17.10.x, errors with cuda 11.8 and 12.1 should be fine to use the -allow-unsupported-compiler as workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants