🔑 Optionally save acquired keys into DB #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuulZone
approved these changes
May 4, 2024
|
Hopefully this gets in. It's kinda annoying. |
Z3rio
suggested changes
Jun 15, 2024
There was a problem hiding this comment.
Lovely PR, and great idea.
But doing it this way is not recommended, as anyone could trigger that server event from their client with any kind of key list.
This should be something to be fully handled on the serverside if it should be secure, qb-core already has enough insecure server events as it is.
|
This PR has had 60 days of inactivity & will close within 7 days |
|
I think this should be considered |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Pull request
This PR makes so the aquired keys will be saved into DB so when the server restarts you will still have the keys you were given. This feature is optional and can be set in the Config file. The PR is made to answer this suggestion [SUGGESTION] Database keys. I believe that is easier to make this into player metadata instead of a full new database table.
Questions (please complete the following information):