Add ability to display torrent "privateness" in UI

[ManiMatter]

Adds private flag to GUI that is available in /info and /properties response

• WebUI & GUI: +"Private" column in torrent list (hidden by default)
• WebUI & GUI: +"Private" flag in properties of selected torrent ("Information" section)

[thalieht]

On the GUI, sorting by the "Private" column does not work.

You have to add the column to TransferlistModel::InternalValue

Problem in General tab in GUI only:

• Select a private torrent
• Select a torrent without metadata
• Private field in General tab is not updated to "No"

[thalieht]

What's the best way to generate a torrent without metadata?

Add a magnet link to session and pause it before its metadata are retrieved.

[stalkerok]

What's the best way to generate a torrent without metadata?

Add a magnet link to session and pause it before its metadata are retrieved.

This can also be done by adding a non-existent magnet link or you can use an existing one by changing a few characters.

[thalieht]

Anyone? Already a pointer where to look to find a solution would be appreciated. I‘m tapping in the dark as to why this happens..

This will take care of it: #20951 (comment)

[ManiMatter]

@stalkerok - is the Windows version still crashing after the additional changes from @Chocobo1 ?
If yes, are there any logs or anything that helps us understand why that might be the case?

[xavier2k6]

Exception Information
MSVCP140!MTX_DO_LOCK+9CIn qbittorrent.exe.6044.dmp the assembly instruction at msvcp140!mtx_do_lock+9c in C:\Windows\System32\msvcp140.dll from Microsoft Corporation has caused an access violation exception (0xC0000005) when trying to read from memory location 0x0000[0](https://github.com/qbittorrent/qBittorrent/pull/20951#B1C1Thread3104)000 on thread 0

@stalkerok Can you grab/install latest Microsoft Visual C++ Redistributable & see if crash still happens.
Microsoft Visual C++ Redistributable Latest Supported Downloads

[glassez]

Separate value corresponding to "n/a" state should be provided in order to sort by "Private" column properly. I believe -1 could do the job.

[ManiMatter]

Thanks - would this work?4595dda

[glassez]

Thanks - would this work?4595dda

No.
Did I suggest returning its string representation?
Isn't it obvious that internalValue() should provide something else (except, of course, the cases when the data itself is string)?
IMO, I made it clear that it is only necessary to add some third value that would correspond to the case when the "privateness" is not available (due to the lack of metadata).

[ManiMatter]

Shall we tag this to milestone 5.0?

[glassez]

Shall we tag this to milestone 5.0?

I don't think this is a good idea for a PR that doesn't have a predictable completion date. It may not make it to v5.0 in time.

[ManiMatter]

@glassez - I was under the impression that this one is pretty much done. Do you see remaining items that need to be addressed?

[glassez]

@glassez - I was under the impression that this one is pretty much done. Do you see remaining items that need to be addressed?

Yes. At least #20951 (comment).

[glassez]

Try to add the following function:

    int customCompare(const QVariant &left, const QVariant &right)
    {
        const bool isLeftValid = left.isValid();
        const bool isRightValid = right.isValid();

        if (isLeftValid == isRightValid)
            return threeWayCompare(left, right);
        return isLeftValid ? -1 : 1;
    }

...and use it to compare "privateness":

case TransferListModel::TR_PRIVATE:
    return customCompare(leftValue, rightValue);

[glassez]

Try to add the following function:

    int customCompare(const QVariant &left, const QVariant &right)
    {
        const bool isLeftValid = left.isValid();
        const bool isRightValid = right.isValid();

        if (isLeftValid == isRightValid)
            return threeWayCompare(left, right);
        return isLeftValid ? -1 : 1;
    }

Or maybe convert an existing one into a template:

// this
int customCompare(const QDateTime &left, const QDateTime &right)
// into
template <typename T>
int customCompare(const T &left, const T &right)