Configs CLI #25
Merged
Configs CLI #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
- Add Dockerfile with 2-stage build (builder and runtime) - Add Dockerfile.runtime for fast runtime-only rebuilds - Update Makefile with Docker build targets (docker_build_builder, docker_build_runtime, docker_build_all) - Install Rust via rustup in init.sh script instead of apt - Add RUST_VERSION to .env configuration - Update CI workflow to cache Rust via rustup - Configure vcpkg caching with BuildKit mount - Fix library and module paths in runtime stage - Set --modules-dir in ENTRYPOINT for convenience (cherry picked from commit e52add2)
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
xDimon
reviewed
Oct 16, 2025
src/app/configurator.cpp
Outdated
| config_->node_key_hex_ = value; | ||
| std::println(file_errors_, | ||
| "E: Value 'general.node_key' must be private key " | ||
| "hex or it's file path"); |
Member
There was a problem hiding this comment.
Should we leave error message here?
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
xDimon
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (auto-generated):
This pull request introduces a multi-stage Docker build for the project, refactors build scripts to improve reproducibility and dependency management, and adds example genesis configuration files for smoke testing. The changes streamline CI, Docker, and Makefile workflows, and enhance Python and Rust environment setup for both local and containerized builds.
Docker and Build System Improvements:
Dockerfile, separating builder and runtime stages, with artifact collection and runtime verification. Also introduced a more granularDockerfile.runtimefor runtime-only images. [1] [2]Makefilewith comprehensive Docker build, run, verify, tag, and push targets, supporting build args and image management for CI/CD and local development. [1] [2]CI and Environment Setup:
.ci/scripts/init.shand.ci/scripts/init_py.shto robustly install Rust viarustup, verify Python availability and venv creation, and ensure proper environment setup for both Python and Rust. [1] [2] [3]Example and Configuration Files:
config.yaml,genesis.json,nodes.yaml,validators.yaml) for smoke testing with four validators and corresponding node/validator assignments. [1] [2] [3] [4]example/config.yaml) to change logging level toinfoand remove the unusedspec_filefield for clarity. [1] [2]