IMP: make reverse primer (adapter) optional for denoise-ccs #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizgehret
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
this all looks reasonable to me, thanks @colinvwood - i'll go ahead and merge this. if the forward primer scenario comes up in the future, we can just plan to address separately.
lizgehret
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #163
Note that the forward primer is still required because the wrapped dada2 function requires it. This is probably because it is needed to orient the sequences. For users who have neither the forward nor the reverse primer and pre-oriented sequences a deeper solution will be necessary, maybe one that skips the call to
removePrimersaltogether.