Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run a filter before outputting the hreflang link #1039

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Run a filter before outputting the hreflang link #1039

wants to merge 3 commits into from

Conversation

reekrd
Copy link

@reekrd reekrd commented Jun 9, 2021

This allows users to skip generating a hreflang link

@herrvigg herrvigg mentioned this pull request Jun 12, 2021
Closed
herrvigg
herrvigg reviewed Jun 12, 2021
View reviewed changes
Copy link
Collaborator

@herrvigg herrvigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made something similar temporarily in master but removed it until the question of the locales is better solved. I'd prefer a unique filter fired once instead of firing for every language.

@herrvigg herrvigg added core Core functionalities, including the admin section enhancement New feature or request labels Jun 12, 2021
@reekrd
Copy link
Author

reekrd commented Jun 13, 2021

Is it a better approach to run it between the two loops?

@herrvigg
Copy link
Collaborator

It could be done with an array indexed by lang, with url and locale. A filter could change/remove some items and QTX would only display what is left.

@herrvigg
Copy link
Collaborator

Ah, i only see the new version now. Yes, something like that, but I'd still need to clarifiy if we need a separation between lang and locale for the hreflang key.

@herrvigg herrvigg force-pushed the master branch 2 times, most recently from 660b9d6 to 2369434 Compare February 19, 2022 23:14
@herrvigg herrvigg mentioned this pull request Mar 28, 2023
Open
@herrvigg
Copy link
Collaborator

Sorry for long delay but it's related to a wider topic with #668 so I have to keep it on hold until this is addressed, lower priority at the moment. Patching the code locally is the only way for now, but I know this is not great 😕

@herrvigg herrvigg force-pushed the master branch 3 times, most recently from 4eda2c7 to 69edb6e Compare April 7, 2023 11:20
@herrvigg herrvigg force-pushed the master branch 2 times, most recently from 5254c56 to e02f557 Compare April 15, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herrvigg herrvigg herrvigg left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
core Core functionalities, including the admin section enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reekrd @herrvigg