Add warning for port override in TEST mode #50785
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log a warning when overriding port in TEST mode.
tomazic89
suggested changes
Oct 30, 2025
extensions/grpc/runtime/src/main/java/io/quarkus/grpc/runtime/supports/Channels.java
Outdated
Show resolved
Hide resolved
…supports/Channels.java Co-authored-by: Nejc Tomažič <[email protected]>
tomazic89
approved these changes
Nov 3, 2025
alesj
reviewed
Nov 3, 2025
| // handle client port | ||
| int port = config.port(); | ||
| if (LaunchMode.current() == LaunchMode.TEST) { | ||
| LOGGER.info("LaunchMode {} detected. Overriding existing port configuration for gRPC client/server .", LaunchMode.TEST); |
There was a problem hiding this comment.
Perhaps suggest a fix via the exact property usage.
It's a bit longer msg, but we have a similar long one for use-separate-server ... ;-)
There was a problem hiding this comment.
Why having a format if you know everything?
cescoffier
requested changes
Nov 4, 2025
| // handle client port | ||
| int port = config.port(); | ||
| if (LaunchMode.current() == LaunchMode.TEST) { | ||
| LOGGER.info("LaunchMode {} detected. Overriding existing port configuration for gRPC client/server .", LaunchMode.TEST); |
There was a problem hiding this comment.
Why having a format if you know everything?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log a warning when overriding port in TEST mode.
As discussed in #35559 the port of gRPC servers and clients is overridden in LaunchMode TEST.
Example:
In order not to change this (probably) desired behaviour and not let people in the future waste hours of their time, at least we now have a warning message.
Fixes #35559