Skip to content

Add warning for port override in TEST mode #50785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add warning for port override in TEST mode #50785

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d9e3ac
Add warning for port override in TEST mode
rogerwalt Oct 30, 2025
6d417cf
Update extensions/grpc/runtime/src/main/java/io/quarkus/grpc/runtime/…
rogerwalt Oct 30, 2025
4a49281
Fix logging statement for LaunchMode.TEST
rogerwalt Oct 30, 2025
807a7df
Merge branch 'main' into rogerwalt-patch-1
rogerwalt Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions extensions/grpc/runtime/src/main/java/io/quarkus/grpc/runtime/supports/Channels.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ public static Channel createChannel(String name, Set<String> perClientIntercepto
// handle client port
int port = config.port();
if (LaunchMode.current() == LaunchMode.TEST) {
LOGGER.info("LaunchMode {} detected. Overriding existing port configuration for gRPC client/server .", LaunchMode.TEST);
Copy link
Contributor

@alesj alesj Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps suggest a fix via the exact property usage.
It's a bit longer msg, but we have a similar long one for use-separate-server ... ;-)

Copy link
Member

@cescoffier cescoffier Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why having a format if you know everything?

port = config.testPort().orElse(testPort(configProvider.getServerConfiguration()));
}

Expand Down
Loading