-
Couldn't load subscription status.
- Fork 36
fix: Allow pop build spec to specify the runtime path as argument
#687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow pop build spec to specify the runtime path as argument
#687
Conversation
|
Tried functionality on Paseo with: and compared the generated raw file with the old one. It looks super good, just one thing caught my attention:
We should be able to include this on Paseo workflows soon ;) |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #687 +/- ##
==========================================
- Coverage 76.95% 76.84% -0.11%
==========================================
Files 109 109
Lines 24609 24549 -60
Branches 24609 24549 -60
==========================================
- Hits 18937 18865 -72
- Misses 3690 3695 +5
- Partials 1982 1989 +7
🚀 New features to boost your workflow:
|
|
Works like a charm! Many thanks for making this command shine ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Excited to see this in the Paseo CI.
Thanks for the last fixes and nitpicks
…ime-dir-as-command
Closes:
pop build spec#685This PR will:
pop build specon CIs (eg, Paseo) by letting the user pass the runtime dir path as argument. This wasn't possible before asfind_runtime_dirautomatically prompts the user if there's not a "runtime" folder on the call path (which is the case for Paseo) <- This isn't nice for CIs.find_workspace_tomlfunction as it's not correctly supporting not prefixed inputs like "system-chains/bridge-hub-paseo". I detected this a while ago when I was working on feat: new commandpop add pallet#524 and added a fixed version to this crate, which was gonna be added to Pop-CLI on that PR. Let's add it now and also leverage we have it to get rid ofadd_crate_to_workspace, reducing pop codebase's size.