chore: update Prometheus blackbox exporter install etc #1280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA:OSPC-1615
rackerchris
requested changes
Oct 29, 2025
base-helm-configs/prometheus-blackbox-exporter/prometheus-blackbox-exporter-helm-overrides.yaml
Show resolved
Hide resolved
I confirmed with a helm --dry-run that this pruned version produced the same output chart.
awfabian-rs
force-pushed
the
PR-prometheus-blackbox-exporter-OSPC-1615
branch
from
dd67226 to
5403689
Compare
awfabian-rs
added a commit
that referenced
this pull request
Oct 31, 2025
…rides the removed lines don't do anything, no value .selfMonitor exists as a top level override for this to have any effect. Additionally, I verified that it doesn't just belong under some other key by looking at the previous overrides: https://github.com/rackerlabs/genestack/blob/c2714f05275cdff06788d199fa64e650fd3faaae/base-helm-configs/prometheus-blackbox-exporter/values.yaml ^F/find selfMonitor, we didn't have any '.something.selfMonitor = enabled' These just look like mysterious extraneous lines I got in there somehow since I previously verified that the pruned overrides produced an identical chart rendering in #1280 JIRA:OSPC-1615
rackerchris
pushed a commit
that referenced
this pull request
Oct 31, 2025
…rides (#1283) the removed lines don't do anything, no value .selfMonitor exists as a top level override for this to have any effect. Additionally, I verified that it doesn't just belong under some other key by looking at the previous overrides: https://github.com/rackerlabs/genestack/blob/c2714f05275cdff06788d199fa64e650fd3faaae/base-helm-configs/prometheus-blackbox-exporter/values.yaml ^F/find selfMonitor, we didn't have any '.something.selfMonitor = enabled' These just look like mysterious extraneous lines I got in there somehow since I previously verified that the pruned overrides produced an identical chart rendering in #1280 JIRA:OSPC-1615
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:OSPC-1615