Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(unique): let toKey return any kind of value #10

Merged
merged 3 commits into from
Jun 25, 2024
Merged

feat(unique): let toKey return any kind of value #10

merged 3 commits into from
Jun 25, 2024

Conversation

aleclarson
Copy link
Member

Description

Allow unique's toKey parameter to return any value, instead of only values that can be identified through a key or those that can be used as keys themselves.

Checklist

  • Changes are covered by tests if behavior has been changed or added
  • Tests have 100% coverage
  • If code changes were made, the documentation (in the /docs directory) has been updated

Resolves

Resolves sodiray/radash#342

@aleclarson aleclarson force-pushed the main branch 12 times, most recently from 3e61d98 to 47f126a Compare June 24, 2024 21:36
@aleclarson aleclarson mentioned this pull request Jun 24, 2024
Closed
@aleclarson
fix(unique): support any value
4154fb8 
…instead of only values that can be identified through a key or can be used as keys themselves.
@aleclarson
test: add a test
da224ea 
Thanks to @jordydhoker for contributing this test: sodiray/radash#343
@aleclarson
fix(unique): skip reduce call if toKey is not defined
17062d1
@aleclarson aleclarson merged commit 3fd8446 into main Jun 25, 2024
4 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2024 •
edited by aleclarson
Loading

A new beta version 12.2.0-beta.362659f has been published to NPM.

To install:

pnpm add [email protected]
See the changes

@aleclarson aleclarson added the new feature This PR adds a new function or extends an existing one label Jun 28, 2024
@aleclarson aleclarson mentioned this pull request Jun 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new feature This PR adds a new function or extends an existing one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unique does not handle non string, number or symbol values correctly
1 participant
@aleclarson