Adds Appraisal and Active Record Tests

[theomelo]

Closes: #120

• Add and configure Appraisal.
• Schedule rails_main tests to run independently from a PR push.
• Configure GitHub Action to run against different Appraisal files:
  • Update .rspec to exclude specs in the ext directory.
  • Create a Rake task that will gather all gemfiles and run the command above with every gemfile.
  • Create a new action that will execute this new Rake task.
• Add test coverage for lib/rage/ext/active_record/connection_pool.rb. Specifically:
  • ActiveRecord::Base.connection_pool.with_connection
  • ActiveRecord::Base.connection_pool.connection
  • ActiveRecord::Base.connection_pool.release_connection
  • ActiveRecord::Base.connection_pool.active_connection?

[rsamoilov]

Hey Theo, great job!

Have several comments right off the bat.

[theomelo]

@rsamoilov I should've asked if you are against using force-push in your PRs before doing so here. I hope you don't mind. 🙇

I updated my PR with the changes you asked for; please let me know if I misunderstood anything. If the current changes are ok, I'll finish adding the tests for the connection_pool methods.

[rsamoilov]

if you are against using force-push

Not at all.

[rsamoilov]

This looks exactly as it should. Love it!

[rsamoilov]

Oh, one more thing - let's remove the Appraisal file and the gemfiles directory from the bundle.

[theomelo]

I updated the workflow to use the cache, but I don't know if it will work as expected. I'll wait for you to approve and fix any errors that might happen.

Another project workflow question: do you prefer having one commit per Pull Request (squash them before merge)?

[rsamoilov]

do you prefer having one commit per Pull Request (squash them before merge)

No, don't worry about the git stuff. Doesn't matter to me.

And sorry for the required approvals, I don't think it's possible to disable that.

[rsamoilov]

Weird, it appears to be working, but it doesn't seem to change anything.
https://github.com/rage-rb/rage/actions/runs/13867738888/job/38848070523?pr=133

[theomelo]

And sorry for the required approvals, I don't think it's possible to disable that.

No worries! There's no reason to be sorry 🙏

Weird, it appears to be working, but it doesn't seem to change anything.
https://github.com/rage-rb/rage/actions/runs/13867738888/job/38848070523?pr=133

I'll investigate this today

[rsamoilov]

Weird, it appears to be working, but it doesn't seem to change anything.

I wonder what will happen if you commit the lockfiles.

[theomelo]

I wonder what will happen if you commit the lockfiles.

My apologies for the radio silence; I was recovering from an accident. I had them originally but removed them after this feedback. I'll add them back and we can see what will happen 🙏

[rsamoilov]

My apologies for the radio silence; I was recovering from an accident.

I'm sorry to hear 😞 Get well soon!

I had them originally but removed them after this feedback

Right, I know I suggested removing them. But considering the cache doesn't work correctly, it is possible committing the lockfiles will fix the issue.

[rsamoilov]

Hey @theomelo

I hope you're doing well.

You've made great progress here, and I'd love to merge the PR. I will continue working in this branch to get it merged, but let me know if you'd prefer to finish it yourself.