-
Notifications
You must be signed in to change notification settings - Fork 25
Adds Appraisal and Active Record Tests #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
478a339
Add Appraisal gem
theomelo 9fbb32b
Run appraisals as a Github Action
theomelo 14fc1d2
Start adding tests
theomelo e5d4fdb
Fix Appraisals GH workflow and ignore gems folder
theomelo ef94c16
Merge branch 'rage-rb:master' into issue-120
theomelo 46cadc7
Merge branch 'rage-rb:master' into issue-120
theomelo 2c12f7b
Add AR tests
rsamoilov a511e94
Update workflow
rsamoilov 7c7a840
Add lockfiles
rsamoilov 2140b87
Disable rails_main
rsamoilov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| name: ActiveRecord Appraisals | ||
|
|
||
| on: | ||
| schedule: [ cron: '0 0 * * *' ] | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| appraise: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| max-parallel: 1 | ||
| matrix: | ||
| ruby: | ||
| - '3.1' | ||
| - '3.2' | ||
| - '3.3' | ||
| - '3.4' | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: Set up Ruby | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: ${{ matrix.ruby }} | ||
| bundler-cache: true | ||
|
|
||
| - name: Resolve appraisals dependencies | ||
| run: bundle exec appraisal install | ||
theomelo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| - name: Run all versioned appraisals | ||
| if: ${{ github.event_name != 'schedule' }} | ||
| run: bundle exec rake appraise | ||
|
|
||
| - name: Run rails_main appraisal | ||
| if: ${{ github.event_name == 'schedule' }} | ||
| run: bundle exec appraisal rails_main rspec spec/ext/* | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,3 +13,6 @@ Gemfile.lock | |
|
|
||
| # rspec failure tracking | ||
| .rspec_status | ||
|
|
||
| # Appraisal's gem lockfiles | ||
| *.gemfile.lock | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| --format documentation | ||
| --color | ||
| --require spec_helper | ||
| --exclude-pattern 'spec/ext/**/**_spec.rb' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| appraise "rails_7_0" do | ||
| gem "activerecord", "~> 7.0.0" | ||
| end | ||
|
|
||
| appraise "rails_7_1" do | ||
| gem "activerecord", "~> 7.1.0" | ||
| end | ||
|
|
||
| appraise "rails_7_2" do | ||
| gem "activerecord", "~> 7.2.0" | ||
| end | ||
|
|
||
| appraise "rails_8_0" do | ||
| gem "activerecord", "~> 8.0.0" | ||
| end | ||
|
|
||
| appraise "rails_main" do | ||
| gem "activerecord", github: "rails/rails" | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,4 +22,5 @@ group :test do | |
| gem "websocket-client-simple" | ||
| gem "prism" | ||
| gem "redis-client" | ||
| gem "appraisal", "~> 2.5" | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # This file was generated by Appraisal | ||
|
|
||
| source "https://rubygems.org" | ||
|
|
||
| gem "rake", "~> 13.0" | ||
| gem "rspec", "~> 3.0" | ||
| gem "yard" | ||
| gem "rubocop", "~> 1.65.0", require: false | ||
| gem "activerecord", "~> 7.0.0" | ||
|
|
||
| group :test do | ||
| gem "http" | ||
| gem "pg" | ||
| gem "mysql2" | ||
| gem "bigdecimal" | ||
| gem "connection_pool", "~> 2.0" | ||
| gem "rbnacl" | ||
| gem "domain_name" | ||
| gem "websocket-client-simple" | ||
| gem "prism" | ||
| gem "redis-client" | ||
| gem "appraisal", "~> 2.5" | ||
| end | ||
|
|
||
| gemspec path: "../" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # This file was generated by Appraisal | ||
|
|
||
| source "https://rubygems.org" | ||
|
|
||
| gem "rake", "~> 13.0" | ||
| gem "rspec", "~> 3.0" | ||
| gem "yard" | ||
| gem "rubocop", "~> 1.65.0", require: false | ||
| gem "activerecord", "~> 7.1.0" | ||
|
|
||
| group :test do | ||
| gem "http" | ||
| gem "pg" | ||
| gem "mysql2" | ||
| gem "bigdecimal" | ||
| gem "connection_pool", "~> 2.0" | ||
| gem "rbnacl" | ||
| gem "domain_name" | ||
| gem "websocket-client-simple" | ||
| gem "prism" | ||
| gem "redis-client" | ||
| gem "appraisal", "~> 2.5" | ||
| end | ||
|
|
||
| gemspec path: "../" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # This file was generated by Appraisal | ||
|
|
||
| source "https://rubygems.org" | ||
|
|
||
| gem "rake", "~> 13.0" | ||
| gem "rspec", "~> 3.0" | ||
| gem "yard" | ||
| gem "rubocop", "~> 1.65.0", require: false | ||
| gem "activerecord", "~> 7.2.0" | ||
|
|
||
| group :test do | ||
| gem "http" | ||
| gem "pg" | ||
| gem "mysql2" | ||
| gem "bigdecimal" | ||
| gem "connection_pool", "~> 2.0" | ||
| gem "rbnacl" | ||
| gem "domain_name" | ||
| gem "websocket-client-simple" | ||
| gem "prism" | ||
| gem "redis-client" | ||
| gem "appraisal", "~> 2.5" | ||
| end | ||
|
|
||
| gemspec path: "../" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # This file was generated by Appraisal | ||
|
|
||
| source "https://rubygems.org" | ||
|
|
||
| gem "rake", "~> 13.0" | ||
| gem "rspec", "~> 3.0" | ||
| gem "yard" | ||
| gem "rubocop", "~> 1.65.0", require: false | ||
| gem "activerecord", "~> 8.0.0" | ||
|
|
||
| group :test do | ||
| gem "http" | ||
| gem "pg" | ||
| gem "mysql2" | ||
| gem "bigdecimal" | ||
| gem "connection_pool", "~> 2.0" | ||
| gem "rbnacl" | ||
| gem "domain_name" | ||
| gem "websocket-client-simple" | ||
| gem "prism" | ||
| gem "redis-client" | ||
| gem "appraisal", "~> 2.5" | ||
| end | ||
|
|
||
| gemspec path: "../" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # This file was generated by Appraisal | ||
|
|
||
| source "https://rubygems.org" | ||
|
|
||
| gem "rake", "~> 13.0" | ||
| gem "rspec", "~> 3.0" | ||
| gem "yard" | ||
| gem "rubocop", "~> 1.65.0", require: false | ||
| gem "activerecord", github: "rails/rails" | ||
|
|
||
| group :test do | ||
| gem "http" | ||
| gem "pg" | ||
| gem "mysql2" | ||
| gem "bigdecimal" | ||
| gem "connection_pool", "~> 2.0" | ||
| gem "rbnacl" | ||
| gem "domain_name" | ||
| gem "websocket-client-simple" | ||
| gem "prism" | ||
| gem "redis-client" | ||
| gem "appraisal", "~> 2.5" | ||
| end | ||
|
|
||
| gemspec path: "../" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| RSpec.describe Rage::Ext::ActiveRecord::ConnectionPool do | ||
| describe ".with_connection" do | ||
| it "works" do | ||
| expect(1 + 1).to eq(2) | ||
| end | ||
| end | ||
| end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.