Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing starting cursor in paginated helper #222

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

smarttommyau
Copy link
Contributor

Allow passing next_cursor to the paginated api to set the starting cursor.

Allow passing next_cursor to the paginated api to set the starting cursor.
Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc03f56) 100.00% compared to head (8fdadac) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #222   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          300       300           
=========================================
  Hits           300       300           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramnes
Copy link
Owner

ramnes commented Dec 25, 2023

I've pushed a commit to stay closer to the TS SDK (and fix CI), does it work for you?

@ramnes ramnes merged commit c1faf0a into ramnes:main Dec 25, 2023
9 checks passed
@ramnes
Copy link
Owner

ramnes commented Dec 25, 2023

Going ahead and merging, please comment if anything's wrong. :)

@smarttommyau smarttommyau deleted the patch-2 branch December 26, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants