Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing starting cursor in paginated helper #222

Merged
merged 2 commits into from
Dec 25, 2023
Merged

Allow passing starting cursor in paginated helper #222

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56b5cbe
Allow passing starting cursor in paginated helper
smarttommyau Dec 24, 2023
8fdadac
Take a slightly different approach
ramnes Dec 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions notion_client/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def iterate_paginated_api(
function: Callable[..., Any], **kwargs: Any
) -> Generator[List[Any], None, None]:
"""Return an iterator over the results of any paginated Notion API."""
next_cursor = None
next_cursor = kwargs.pop("start_cursor", None)

while True:
response = function(**kwargs, start_cursor=next_cursor)
Expand All @@ -53,7 +53,7 @@ async def async_iterate_paginated_api(
function: Callable[..., Awaitable[Any]], **kwargs: Any
) -> AsyncGenerator[List[Any], None]:
"""Return an async iterator over the results of any paginated Notion API."""
next_cursor = None
next_cursor = kwargs.pop("start_cursor", None)

while True:
response = await function(**kwargs, start_cursor=next_cursor)
Expand Down
Loading