Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve agent logs dir default permissions #6276

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

brandond
Copy link
Member

@brandond brandond commented Jul 2, 2024

Proposed Changes

Improve agent logs dir default permissions

This one goes all the way back!

Types of Changes

enhancement

Verification

Check dir permissions

Testing

Linked Issues

User-Facing Change

Further Comments

@brandond brandond requested a review from a team as a code owner July 2, 2024 18:59
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 26.09%. Comparing base (f01072a) to head (12952a3).

Files Patch % Lines
pkg/cli/defaults/defaults.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6276   +/-   ##
=======================================
  Coverage   26.09%   26.09%           
=======================================
  Files          32       32           
  Lines        2698     2698           
=======================================
  Hits          704      704           
  Misses       1948     1948           
  Partials       46       46           
Flag Coverage Δ
inttests 9.82% <0.00%> (ø)
unittests 18.57% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants