Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data-dir to uninstall and killall scripts #6296

Merged

Conversation

jakefhyde
Copy link
Contributor

@jakefhyde jakefhyde commented Jul 9, 2024

Proposed Changes

Add RKE2_DATA_DIR as an optional environment variable to the rke2-killall.sh,rke2-uninstall.sh, and rke2-uninstall.ps1 scripts.

Types of Changes

Bugfix

Verification

Installing RKE2 with a custom data-dir (not /var/lib/rancher/rke2), and running the killall and uninstall scripts, verifying assets in /var/lib/rancher/rke2 are properly removed.

Testing

This is not currently covered by testing, though I would be happy to write an integration test if need be.

Linked Issues

User-Facing Change

NONE

Further Comments

Relates to rancher/rancher#46066.

@jakefhyde jakefhyde requested a review from a team as a code owner July 9, 2024 21:18
@jakefhyde jakefhyde changed the title Add data-dir to uninstall and killall scripts Add data-dir to uninstall and killall scripts Jul 9, 2024
bundle/bin/rke2-killall.sh Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.95%. Comparing base (8121a5e) to head (39d9fe3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6296   +/-   ##
=======================================
  Coverage   25.95%   25.95%           
=======================================
  Files          32       32           
  Lines        2712     2712           
=======================================
  Hits          704      704           
  Misses       1962     1962           
  Partials       46       46           
Flag Coverage Δ
inttests 9.77% <ø> (ø)
unittests 18.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakefhyde jakefhyde force-pushed the 6292-add-data-dir-to-uninstall-and-killall branch from 38a27a7 to 39d9fe3 Compare July 9, 2024 21:36
@jakefhyde jakefhyde requested a review from brandond July 9, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants