Remove specific versions in dev script #843
Open
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danil-Grigorev <[email protected]>
4 tasks
yiannistri
approved these changes
Nov 6, 2024
salasberryfin
approved these changes
Nov 6, 2024
| --set core=cluster-api:v1.7.7 \ | ||
| --set controlPlane=rke2:v0.8.0 \ | ||
| --set bootstrap=rke2:v0.8.0 \ | ||
| --set infrastructure=docker \ |
There was a problem hiding this comment.
the only objective I would have is: with this change, as of now we start installing CAPI v1.8.5 (=latest) and CAPRKE2 v0.8.0 (=latest) where latter is compatible only with CAPI v1.7.x series
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Dev script requires specific versions for CAPI providers.
This PR proposes removing specific version requirements. Current pinned version (v1.7.7) of CAPRKE2 is not compatible with turtles, as agent install command causes continuous remediation of CP machines. This problem was fixed with latest.
Additionally, a pinned version requires regular bumps with
updatecli, which increases complexity of the automation, focused only on maintaining dev environment.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: