-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow GeoSeries from accepting a column in favor of _from_column
#1434
Conversation
_from_column
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: are cudf.Series._*
methods considered private? If so, it makes me nervous to add more private cudf access in cuspatial.
I don't think there is an alternative path here. Previously, constructing a |
Looks like some CI tests are failing:
|
/merge |
Description
closes #1433
Mirroring the upstream cudf changes in rapidsai/cudf#16454,
cudf.Series
disallows accepting aColumnBase
in favor of thecudf.Series._from_column
constructor. This PR does the same forGeoSeries
as well as addresses the breakages due to the upstream cudf change.Checklist